Make acceptance tests runnable with key-pair auth only#173
Closed
bbhorrigan wants to merge 2 commits intohashicorp:mainfrom
Closed
Make acceptance tests runnable with key-pair auth only#173bbhorrigan wants to merge 2 commits intohashicorp:mainfrom
bbhorrigan wants to merge 2 commits intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Author
|
Hey, I also work at Snowflake and emailed John-Michael last week about this change. I tested this quite a bit and went through acceptance testing as requested, and found a couple of small bugs along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Snowflake is deprecating password authentication (see #172), but the acceptance test suite hard-requires
SNOWFLAKE_PASSWORDviadsnString(), making the entire suite impossible to run with only key-pair credentials. This PR makes password-dependent tests optional so the suite runs with key-pair auth alone.SNOWFLAKE_PASSWORDis unsetTestSnowflake_NewUsernow use key-pair admin connections for initialization and cleanupTestSnowflake_RenewUser_KeyPairandTestSnowflake_RevokeUser_KeyPairtests cover critical flows without password authgetKeyPairAuthParametersthat useduserinstead ofaccountin the connection URL (introduced in Add support for keypair root configuration #109), causing key-pair SQL operations to hit the wrong hostverifyConnWithKeyPairCredentialwhich usedParseDSNthat rejects empty passwords even for JWT auth, making key-pair verification impossibleTest plan
go vet ./...andgo build ./...passgo test -v -run 'TestGetSnowflakeConfig|TestGetPrivateKey|TestConnectionProducer' ./...Closes #172