-
Notifications
You must be signed in to change notification settings - Fork 120
Extend helm chart to improve controller availability #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
@MM53 are you still interested in contributing this? I need the priorityClassName change and would like to help push this across the line if so. |
Yes, this change would still be helpful for us. |
@MM53 It seems like checks got stuck on this PR. Do you want to re-run them or open a new PR to kick them off again? I'm told that once the checks (including CLA) all pass, this PR will be sent to the reviewing team for their approval. You can also reach out to me at firstName.lastName @ (employer in my profile).com if you want to work through this more directly. |
be653f9
to
2f85481
Compare
@andrewseling I updated the branch to resolve any conflicts, but I guess the missing check needs to be triggered by some reviewer since I don't have a possibility to run it. |
@benashz Thanks for giving this a push! So I can set expectations with my customer, do you have any estimate for when this change might proceed to review + merge + release? |
While installing the operator in our setup we did some modifications to the resources to improve the availability of the controller Pods. Since those changes might also help others, it would be great to include them in the Helm chart.
Following changes were applied:
priorityClassName
of the Deployment and Jobs. This supports proper handling of scheduling and eviction in case of low resourcestopologySpreadConstraints
of the controller Pods. This provides a more detailed control of Pod placement thanaffinity
rules.PodDisruptionBudget
to avoid evicting all controller Pods at once in case there are multiple replicas.Please let me know what you think about these changes.