docs: add -download ent command option for plugin register - #31196
Merged
maithyton merged 3 commits intoJul 3, 2025
Conversation
github-actions
Bot
added
the
hashicorp-contributed-pr
maithyton
added
pr/no-changelog
and removed
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
schavis
requested changes
Jul 3, 2025
| Register a plugin with download: | ||
|
|
||
| ```shell-session | ||
| $ vault plugin register |
Contributor
There was a problem hiding this comment.
We generally try to avoid using comments in example code to explain what's happening in the command. We should move the information to the intro sentence for the example. I added a suggestion to that effect.
schavis
requested changes
Jul 3, 2025
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
github-actions
Bot
added
the
hashicorp-contributed-pr
schavis
approved these changes
Jul 3, 2025
Merged
9 tasks
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
…#31196) --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
The PR documents
-downloadent command option forplugin registerTODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.