Skip to content

OSS Patch: Move metrics methods used in ENT to ENT file - #31206

Merged
aslamovamir merged 1 commit into
mainfrom
move-ent--metrics-methods-out-ce-oss
Jul 3, 2025
Merged

OSS Patch: Move metrics methods used in ENT to ENT file#31206
aslamovamir merged 1 commit into
mainfrom
move-ent--metrics-methods-out-ce-oss

Conversation

@aslamovamir

@aslamovamir aslamovamir commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Description

What does this PR do?
This PR is a code quality PR that moves metrics method used only in ENT to an ENT file.
Associated ENT PR: https://github.com/hashicorp/vault-enterprise/pull/8410

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@aslamovamir
aslamovamir requested a review from a team as a code owner July 3, 2025 18:35
@aslamovamir
aslamovamir requested a review from cinthiaconti July 3, 2025 18:35
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 3, 2025
@aslamovamir
aslamovamir requested a review from VioletHynes July 3, 2025 18:36
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@VioletHynes VioletHynes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this :)

@aslamovamir
aslamovamir merged commit 5ec122f into main Jul 3, 2025
102 checks passed
@aslamovamir
aslamovamir deleted the move-ent--metrics-methods-out-ce-oss branch July 3, 2025 20:31
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants