Skip to content

Add additional validations to the destination and properties of file audit sinks - #31211

Merged
sgmiller merged 4 commits into
mainfrom
sgm/audit-log-target-verif
Jul 8, 2025
Merged

Add additional validations to the destination and properties of file audit sinks#31211
sgmiller merged 4 commits into
mainfrom
sgm/audit-log-target-verif

Conversation

@sgmiller

@sgmiller sgmiller commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@sgmiller
sgmiller requested a review from a team as a code owner July 3, 2025 20:46
@sgmiller
sgmiller requested a review from bosouza July 3, 2025 20:46
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 3, 2025
@sgmiller
sgmiller requested a review from a team July 3, 2025 20:47
@sgmiller sgmiller added this to the 1.20.1 milestone Jul 3, 2025
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@sgmiller
sgmiller requested review from a team as code owners July 3, 2025 20:52
stevendpclark
stevendpclark previously approved these changes Jul 3, 2025
This reverts commit c2e8f76.
@sgmiller
sgmiller requested review from stevendpclark and removed request for a team July 7, 2025 18:36
@sgmiller
sgmiller merged commit 63ba96c into main Jul 8, 2025
91 checks passed
@sgmiller
sgmiller deleted the sgm/audit-log-target-verif branch July 8, 2025 18:33
pixambi added a commit to hashicorp/web-unified-docs that referenced this pull request Aug 5, 2025
…-6000)

Added details to upgrade and important changes docs for Vault versions 1.16.x, 1.18.x, 1.19.x, and 1.20.x about new requirements for file audit devices: explicit configuration for prefixing, restrictions on writing to plugin directories, and prohibition of executable file permissions. Recommendations for configuration updates are provided.

Fixes introduced in hashicorp/vault#31211 for CVE-2025-6000.
pixambi added a commit to hashicorp/web-unified-docs that referenced this pull request Aug 8, 2025
…-6000) (#682)

Added details to upgrade and important changes docs for Vault versions
1.16.x, 1.18.x, 1.19.x, and 1.20.x about new requirements for file audit
devices: explicit configuration for prefixing, restrictions on writing
to plugin directories, and prohibition of executable file permissions.
Recommendations for configuration updates are provided.

Fixes introduced in hashicorp/vault#31211 for CVE-2025-6000.
hashibot-web pushed a commit to hashicorp/web-unified-docs that referenced this pull request Aug 14, 2025
…-6000)

Added details to upgrade and important changes docs for Vault versions 1.16.x, 1.18.x, 1.19.x, and 1.20.x about new requirements for file audit devices: explicit configuration for prefixing, restrictions on writing to plugin directories, and prohibition of executable file permissions. Recommendations for configuration updates are provided.

Fixes introduced in hashicorp/vault#31211 for CVE-2025-6000.
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
…audit sinks (hashicorp#31211)

* Add additional validations to the destination and properties of file audit sinks

* changelog

* docs

* Revert "docs"

This reverts commit c2e8f76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants