Fix calculation of full mount path in pathInternalUIMountRead. - #31214
Closed
victorr wants to merge 2 commits into
Closed
Fix calculation of full mount path in pathInternalUIMountRead.#31214victorr wants to merge 2 commits into
victorr wants to merge 2 commits into
Conversation
The calculation of the full mount path was wrong when the namespace in the context is not the same as the one in the mount entry, and the namespace is a nested one.
|
CI Results: |
|
Build Results: |
victorr
force-pushed
the
victorr/vault-36301-ce-nested-namespace-fix
branch
from
July 4, 2025 15:32
d4d2fa0 to
443e9d5
Compare
Contributor
Author
|
Closing without merging since the fix was not correct and the issue was taken over by https://github.com/hashicorp/vault-enterprise/pull/8840. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The calculation of the full mount path was wrong when the namespace in the context is not the same as the one in the mount entry, and the namespace is a nested one.
This is the CE counterpart to PR https://github.com/hashicorp/vault-enterprise/pull/8405
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.