Skip to content

Fix calculation of full mount path in pathInternalUIMountRead. - #31214

Closed
victorr wants to merge 2 commits into
mainfrom
victorr/vault-36301-ce-nested-namespace-fix
Closed

Fix calculation of full mount path in pathInternalUIMountRead.#31214
victorr wants to merge 2 commits into
mainfrom
victorr/vault-36301-ce-nested-namespace-fix

Conversation

@victorr

@victorr victorr commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

Description

The calculation of the full mount path was wrong when the namespace in the context is not the same as the one in the mount entry, and the namespace is a nested one.

This is the CE counterpart to PR https://github.com/hashicorp/vault-enterprise/pull/8405

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

The calculation of the full mount path was wrong when the namespace in the
context is not the same as the one in the mount entry, and the namespace is
a nested one.
@victorr victorr added this to the 1.20.1 milestone Jul 4, 2025
@victorr victorr self-assigned this Jul 4, 2025
@victorr
victorr requested a review from a team as a code owner July 4, 2025 15:21
@victorr
victorr requested a review from tomcf-hcp July 4, 2025 15:21
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 4, 2025
@victorr
victorr requested a review from davidadeleon July 4, 2025 15:24
@github-actions

github-actions Bot commented Jul 4, 2025

Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions

github-actions Bot commented Jul 4, 2025

Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@victorr
victorr force-pushed the victorr/vault-36301-ce-nested-namespace-fix branch from d4d2fa0 to 443e9d5 Compare July 4, 2025 15:32
@lursu lursu modified the milestones: 1.20.1, 1.20.2 Jul 24, 2025
@tomcf-hcp tomcf-hcp modified the milestones: 1.20.2, 1.20.3 Aug 7, 2025
@victorr

victorr commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Closing without merging since the fix was not correct and the issue was taken over by https://github.com/hashicorp/vault-enterprise/pull/8840.

@victorr victorr closed this Nov 3, 2025
@victorr
victorr deleted the victorr/vault-36301-ce-nested-namespace-fix branch November 3, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants