Skip to content

Add digest OID to PKCS7/SCEP digest failure logs - #31232

Merged
stevendpclark merged 3 commits into
mainfrom
stevendpclark/vault-37995-extra-digest-debugging
Jul 9, 2025
Merged

Add digest OID to PKCS7/SCEP digest failure logs#31232
stevendpclark merged 3 commits into
mainfrom
stevendpclark/vault-37995-extra-digest-debugging

Conversation

@stevendpclark

Copy link
Copy Markdown
Contributor

Description

To help debugging in the future without requiring a full packet capture lets add the digest OID that we used to select the hashing algorithm that led to the digest mismatch

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

 - To help debugging in the future without requiring a full packet capture
   lets add the digest oid that we used to select the hashing algorithm that
   led to the digmest mismatch
@stevendpclark stevendpclark added this to the 1.20.1 milestone Jul 9, 2025
@stevendpclark
stevendpclark requested a review from a team July 9, 2025 13:41
@stevendpclark stevendpclark self-assigned this Jul 9, 2025
@stevendpclark
stevendpclark requested a review from a team as a code owner July 9, 2025 13:41
@stevendpclark
stevendpclark requested a review from jkaufman-hc July 9, 2025 13:41
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 9, 2025
@stevendpclark stevendpclark changed the title Stevendpclark/vault 37995 extra digest debugging Add digest OID to PKCS7/SCEP digest failure logs Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@victorr victorr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevendpclark
stevendpclark merged commit d9aa824 into main Jul 9, 2025
91 checks passed
@stevendpclark
stevendpclark deleted the stevendpclark/vault-37995-extra-digest-debugging branch July 9, 2025 14:54
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
* Add digest OID to PKCS7/SCEP digest failure logs

 - To help debugging in the future without requiring a full packet capture
   lets add the digest oid that we used to select the hashing algorithm that
   led to the digmest mismatch

* Add cl

* Fix type in CL header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed secret/pki

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants