Skip to content

Add DB type consts #31295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliesterner merged 5 commits into from
Jul 17, 2025
Merged

Add DB type consts #31295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1407433
add necessary consts
elliesterner Jul 15, 2025
63be099
add other db plugins
elliesterner Jul 15, 2025
6544255
correct ES
elliesterner Jul 15, 2025
9ccb94c
Fix consts in test
elliesterner Jul 15, 2025
e10afc7
Merge branch 'main' into VAULT-32655/refactor-consts
elliesterner Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions builtin/logical/database/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,8 +1665,8 @@ func TestBackend_GetConnectionMetrics(t *testing.T) {
cassandraConfig,
},
expectedCounts: map[string]int{
pluginconsts.DbPostgresqlPlugin: 1,
pluginconsts.DbCassandraPlugin: 1,
pluginconsts.DbPostgresqlPluginType: 1,
pluginconsts.DbCassandraPluginType: 1,
},
},
{
Expand All @@ -1675,7 +1675,7 @@ func TestBackend_GetConnectionMetrics(t *testing.T) {
postgresConfig,
},
expectedCounts: map[string]int{
pluginconsts.DbPostgresqlPlugin: 1,
pluginconsts.DbPostgresqlPluginType: 1,
},
},
{
Expand All @@ -1692,8 +1692,8 @@ func TestBackend_GetConnectionMetrics(t *testing.T) {
cassandraConfigV2,
},
expectedCounts: map[string]int{
pluginconsts.DbPostgresqlPlugin: 2,
pluginconsts.DbCassandraPlugin: 2,
pluginconsts.DbPostgresqlPluginType: 2,
pluginconsts.DbCassandraPluginType: 2,
},
},
}
Expand Down
26 changes: 18 additions & 8 deletions helper/pluginconsts/plugin_consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ const (
AuthTypeSAML = "saml"
AuthTypeApprole = "approle"
AuthTypeJWT = "jwt"
DbCassandraPlugin = "cassandra"
DbHanaPlugin = "hdb"
DbInfluxDBPlugin = "influxdb"
DbMongoDBPlugin = "mongodb"
DbMsSQLPlugin = "mssql"
DbMySQLPlugin = "mysql"
DbRedshiftPlugin = "redshift"
DbPostgresqlPlugin = "pgx"
SecretEngineAD = "ad"
SecretEngineAlicloud = "alicloud"
SecretEngineAWS = "aws"
Expand Down Expand Up @@ -71,3 +63,21 @@ const (
// database type for every database.
SecretEngineDatabase = "database"
)

// These DB consts match the type returned from database plugin's Type() method.
const (
DbCassandraPluginType = "cassandra"
DbCouchbasePluginType = "couchbase"
DbElasticSearchPluginType = "elasticsearch"
DbHanaPluginType = "hdb"
DbInfluxDBPluginType = "influxdb"
DbMongoDBPluginType = "mongodb"
DbMongoAtlasPluginType = "mongodbatlas"
DbMsSQLPluginType = "mssql"
DbMySQLPluginType = "mysql"
DbPostgresqlPluginType = "pgx"
DbRedshiftPluginType = "redshift"
DbRedisPluginType = "redis"
DbRedisElasticachePluginType = "redisElastiCache"
DbSnowflakePluginType = "snowflake"
)
1 change: 1 addition & 0 deletions vault/mount.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ const (
mountTypeNSCubbyhole = "ns_cubbyhole"
mountTypeToken = "token"
mountTypeNSToken = "ns_token"
mountTypeDatabase = "database"

MountTableUpdateStorage = true
MountTableNoUpdateStorage = false
Expand Down
Loading