fix: respect NO_PROXY CIDR notation in Vault CLI HTTP client#31976
Open
RoySerbi wants to merge 1 commit into
Open
fix: respect NO_PROXY CIDR notation in Vault CLI HTTP client#31976RoySerbi wants to merge 1 commit into
RoySerbi wants to merge 1 commit into
Conversation
When VAULT_HTTP_PROXY or VAULT_PROXY_ADDR is set, the Vault CLI uses http.ProxyURL() which always routes through the proxy regardless of NO_PROXY entries. This means CIDR notation in NO_PROXY (e.g., 10.66.0.0/16) is ignored. This fix replaces http.ProxyURL() with a custom proxy function that checks NO_PROXY entries before routing through the proxy, supporting: - Exact hostname matching - Domain suffix matching (.example.com) - CIDR subnet matching (10.66.0.0/16) Fixes hashicorp#31954 Signed-off-by: RoySerbi <roy676564@gmail.com>
|
@RoySerbi is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #31954
When
VAULT_HTTP_PROXYorVAULT_PROXY_ADDRis set, the Vault CLI useshttp.ProxyURL()which always routes through the proxy regardless ofNO_PROXYentries. This means CIDR notation inNO_PROXY(e.g.,10.66.0.0/16) is ignored.Root cause
In
api/client.go, the proxy is configured with:http.ProxyURLreturns a function that always returns the given proxy URL, completely ignoring theNO_PROXYenvironment variable.Fix
Replace
http.ProxyURL()with a custom proxy function that checksNO_PROXYentries before routing through the proxy, supporting:localhost).mycompany.tld)10.66.0.0/16)When a host matches a
NO_PROXYentry, the proxy is bypassed (returnsnil, nil).