transit: warn when context is ignored on non-derived keys - #32076
Open
SashaMIT wants to merge 1 commit into
Open
transit: warn when context is ignored on non-derived keys#32076SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
encrypt/decrypt accept context even when the key has derivation disabled, then silently ignore it via GetKey's non-derived fast path. Operators can believe they have per-context isolation while ciphertext decrypts without context. Emit a response warning; behavior unchanged. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
|
Deployment failed for project vault-ui with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Closing to reopen as non-draft; GitHub denied markReadyForReview for this fork PR. |
SashaMIT
marked this pull request as ready for review
August 8, 2026 12:41
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transit
encrypt/decryptaccept acontextparameter even when the key has derivation disabled.GetKeythen takes the non-derived fast path and silently ignores that context, so operators can believe they have per-context isolation while ciphertext still decrypts without (or with a different) context.This PR emits a response warning when
contextis supplied on a non-derived key for encrypt/decrypt. Cryptographic behavior is unchanged (still ignore context; no hard fail), so existing clients keep working while the warning makes the footgun visible.TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch.PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
Revert: Revert this PR; no migration or data change.
Security-control impact: Adds an operator-visible warning only. No new authz path, no change to encrypt/decrypt success criteria, no logging pipeline change.