Skip to content

Conversation

@rkoron007
Copy link
Contributor

@rkoron007 rkoron007 commented Nov 18, 2025

Adding the redirects for the first 163 rows (everything above the orange line) in the 404 sheet!

@rkoron007 rkoron007 requested review from a team as code owners November 18, 2025 19:34
@rkoron007 rkoron007 self-assigned this Nov 18, 2025
@github-actions github-actions bot added HCP Terraform Sentinel Sentinel documentation labels Nov 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Tue Dec 2 21:18:54 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Tue Dec 2 21:13:19 UTC 2025

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Broken Link Checker

No broken links found! 🎉

},
// HCP Terraform rebranding
{
"source": "/terraform/language/settings/terraform-cloud",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved all the terraform/language/settings/terraform-cloud redirects down together below!

"permanent": true
},
// Reorg terraform block reference
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I moved all these + versioning below

"permanent": true
},
{
"source": "/terraform/language/v:version(1\\.(?:[1-9]|1[01])\\.x)/validate",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks is a better redirect here, so doing that instead!

},
// /terraform → block/terraform
{
"source": "/terraform/language/terraform",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this with all the terraform settings redirects below

"permanent": true
},
{
"source": "/terraform/cli/v:version(1\\.(?:1[1-9]|[2-9]\\d)\\.x|[2-9]\\d*\\.\\d+\\.x)/commands/env",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these 1.10.x links, instead of letting all future versions 404 I boot them to the last time this page existed because it has an explicit deprecation notice.

"permanent": true
},
{
"source": "/terraform/cloud-docs/api-docs/admin/:slug",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no admin API for TFC, so I just boot them to the main page. I figure that's better than a 404, and they can see in the sidebar that Admin doesn't exist.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a redirect for the /admin and one for /admin/:slug. Otherwise, the path the just /admin won't work.

"permanent": true
},
{
"source": "/terraform/cloud-docs/workspaces/run",
Copy link
Contributor Author

@rkoron007 rkoron007 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No overview page, so booting to the first page available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't already have one, we should create task to write a proper overview or concept page about runs and remove this redirect after publishing it.

},
{
"source": "/terraform/intro/v:version(1\\.(?:1|2|3|4|5|6|7|8)\\.x)/phases/:slug*",
"destination": "/terraform/intro/phases/:slug*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use versions for any of the intro links, because folks should always see the most up to date version!

},
{
"source": "/terraform/language/v:version(1\\.(?:[3-9]|[1-9]\\d)\\.x|[2-9]\\d*\\.\\d+\\.x)/functions/defaults",
"destination": "/terraform/language/v:version/functions",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main page felt like the best place to redirect to.

},
{
"source": "/terraform/language/configuration-0-11/:slug*",
"destination": "/terraform/language/v1.1.x/configuration-0-11/:slug*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only on 1.1, so I redirect there.

"permanent": true
},
{
"source": "/terraform/cli/v:version(1\\.(?:1[1-9]|[2-9]\\d)\\.x|[2-9]\\d*\\.\\d+\\.x)/import/importability",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page went away, so I just redirect to the related page in sdkv2

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Almost everything seems to work. I found a few places where the "v" was left out of the expression, but I'm not positive that my suggestions added it to the correct place.

There is also some inconsistency where the site redirects on the path segment before the slug but not others. I wonder if it has to do with the implied index.mdx, versus the folder name?

Approving so you can merge after having a look.

Thanks for cleaning up all of our messes.

Comment on lines +775 to +777
"source": "/terraform/language/v:version(1\\.(?:1|2|3|4|5|6|7|8|9|10|11)\\.x)/state/remove",
"destination": "/terraform/cli/:version/commands/state/rm",
"permanent": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"source": "/terraform/language/v:version(1\\.(?:1|2|3|4|5|6|7|8|9|10|11)\\.x)/state/remove",
"destination": "/terraform/cli/:version/commands/state/rm",
"permanent": true
"source": "/terraform/language/v:version(v1\\.(?:1|2|3|4|5|6|7|8|9|10|11)\\.x)/state/remove",
"destination": "/terraform/cli/:version/commands/state/rm",
"permanent": true

Right? When the site switches to the destination, it is leaving out the "v" part of the version string.

Comment on lines +820 to +822
"source": "/terraform/cli/v:version(1\\.(?:1|2|3|4|5)\\.x)/test",
"destination": "/terraform/cli/:version/commands/test",
"permanent": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"source": "/terraform/cli/v:version(1\\.(?:1|2|3|4|5)\\.x)/test",
"destination": "/terraform/cli/:version/commands/test",
"permanent": true
"source": "/terraform/cli/:version(v1\\.(?:1|2|3|4|5)\\.x)/test",
"destination": "/terraform/cli/:version/commands/test",
"permanent": true

Double check this regex. The same thing is happening for this one as line 777

"permanent": true
},
{
"source": "/terraform/cloud-docs/api-docs/admin/:slug",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a redirect for the /admin and one for /admin/:slug. Otherwise, the path the just /admin won't work.

"permanent": true
},
{
"source": "/terraform/cloud-docs/workspaces/run",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't already have one, we should create task to write a proper overview or concept page about runs and remove this redirect after publishing it.

Comment on lines +1020 to +1024
{
"source": "/terraform/language/v:version(1\\.(?:1|2|3|4|5|6|7|8)\\.x)/backend/:slug*",
"destination": "/terraform/language/v:version/settings/backends/:slug*",
"permanent": true
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"source": "/terraform/language/v:version(1\\.(?:1|2|3|4|5|6|7|8)\\.x)/backend/:slug*",
"destination": "/terraform/language/v:version/settings/backends/:slug*",
"permanent": true
},
{
"source": "/terraform/language/v:version(1\\.(?:1|2|3|4|5|6|7|8)\\.x)/backend/:slug*",
"destination": "/terraform/language/v:version/settings/backends/:slug*",
"permanent": true
},

I think you also need this one without the slug because, for example, /terraform/language/v1.8.x/settings/backend, isn't redirecting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't know why this one isn't working. The preview is redirecting some paths on the segment before the slug but not others.

Comment on lines +8 to +10
"source": "/sentinel/docs/:version(0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfconfig-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfconfig-v2",
"permanent": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"source": "/sentinel/docs/:version(0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfconfig-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfconfig-v2",
"permanent": true
"source": "/sentinel/docs/:version(v0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfconfig-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfconfig-v2",
"permanent": true

Missing the "v" somewhere. I think this is where it's supposed to go.

Comment on lines +13 to +15
"source": "/sentinel/docs/:version(0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfplan-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfplan-v2",
"permanent": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"source": "/sentinel/docs/:version(0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfplan-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfplan-v2",
"permanent": true
"source": "/sentinel/docs/:version(v0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfplan-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfplan-v2",
"permanent": true

same here

Comment on lines +18 to +20
"source": "/sentinel/docs/:version(0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfstate-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfstate-v2",
"permanent": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"source": "/sentinel/docs/:version(0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfstate-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfstate-v2",
"permanent": true
"source": "/sentinel/docs/:version(v0\\.(?:27|28|29|30)\\.x)/docs/features/terraform/tfstate-v2",
"destination": "/sentinel/docs/:version/features/terraform/tfstate-v2",
"permanent": true

And here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HCP Terraform Sentinel Sentinel documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants