-
Notifications
You must be signed in to change notification settings - Fork 112
Consul Docs: Azure auto-join MSI clarification #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nphilbrook
wants to merge
2
commits into
hashicorp:main
Choose a base branch
from
nphilbrook:nphilbrook_azure_auto_join
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
boruszak
reviewed
Nov 26, 2025
Contributor
boruszak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement suggestions for style guide alignment.
Comment on lines
+194
to
+200
| <Note> | ||
|
|
||
| If any of the tentant, client, or client_secret arguments are omitted, then Consul will fall back to Managed Service Identities (see below) and | ||
| any client_id that _was_ specified will be ignored for the purposes of MSI. To pass a specific client_id to MSI (for example, | ||
| to use a User-Managed identity on a VM that also has a System-Managed identity, you must use the environment variable `AZURE_CLIENT_ID` (reference the [Azure autorest package documentation](https://github.com/Azure/go-autorest/blob/autorest/v0.11.29/autorest/azure/auth/auth.go#L43) | ||
|
|
||
| </Note> |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| <Note> | |
| If any of the tentant, client, or client_secret arguments are omitted, then Consul will fall back to Managed Service Identities (see below) and | |
| any client_id that _was_ specified will be ignored for the purposes of MSI. To pass a specific client_id to MSI (for example, | |
| to use a User-Managed identity on a VM that also has a System-Managed identity, you must use the environment variable `AZURE_CLIENT_ID` (reference the [Azure autorest package documentation](https://github.com/Azure/go-autorest/blob/autorest/v0.11.29/autorest/azure/auth/auth.go#L43) | |
| </Note> | |
| If you omit any of the `TENANT`, `CLIENT`, or `CLIENT_SECRET` arguments, then Consul defaults to Managed Service Identities instead. Any client identification that was specified is ignored for the purposes of MSI. To pass client identity to MSI, you must use the `AZURE_CLIENT_ID` environment variable. For more information, refer to the [Azure autorest package documentation](https://github.com/Azure/go-autorest/blob/autorest/v0.11.29/autorest/azure/auth/auth.go#L43). |
Style guide alignments and sentence simplification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While figuring out how to use Azure auto-join from VMs with both a System-managed identity and a User-managed identity, when I needed to use the User-managed identity, I stumbled on some serious pain. This is probably not the best way to explain it, but I wanted others to benefit from my journey of pain. I will happily accept any suggestions on wording, organization, or verbiage. The 2 main points I want to get across that I discovered from reading both the go-discover code and the Azure/go-autorest code are that:
AZURE_CLIENT_IDand NOTARM_CLIENT_ID. Code references from Azure/go-autorest:Contributor checklists
Review urgency:
Pull request:
Content:
Reviewer checklist