Nomad Docs: Add new QEMU driver parameters #1416
Open
+42
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
aimeeu
approved these changes
Dec 2, 2025
Contributor
aimeeu
left a comment
aimeeu
left a comment
There was a problem hiding this comment.
Thanks! I left a few style guide suggestions.
content/nomad/v1.11.x/content/docs/job-declare/task-driver/qemu.mdx
Outdated
Show resolved
Hide resolved
Comment on lines
17
to
23
| In Nomad 1.11.1, `emulator` and `machine_type` were added to the task config, | ||
| and `fingerprint_emulator` was added to the driver config. These default to the | ||
| previously used values of `qemu-system-x86_64`, and `pc`. Previously, when using | ||
| the `kvm` accelerator, the machine type `host` was forced. This is no longer true, | ||
| the value for `machine_type` will be used. Additionally, if using resources.cores, | ||
| with the `kvm` accelerator, the `-smp` was hardcoded to that number of cores. This | ||
| is now only done if the user has not specified a custom -smp flag. |
Contributor
There was a problem hiding this comment.
Suggested change
| In Nomad 1.11.1, `emulator` and `machine_type` were added to the task config, | |
| and `fingerprint_emulator` was added to the driver config. These default to the | |
| previously used values of `qemu-system-x86_64`, and `pc`. Previously, when using | |
| the `kvm` accelerator, the machine type `host` was forced. This is no longer true, | |
| the value for `machine_type` will be used. Additionally, if using resources.cores, | |
| with the `kvm` accelerator, the `-smp` was hardcoded to that number of cores. This | |
| is now only done if the user has not specified a custom -smp flag. | |
| In Nomad 1.11.1, we added `emulator` and `machine_type` to the task config and | |
| `fingerprint_emulator` to the driver config. These default to the previously | |
| used values of `qemu-system-x86_64` and `pc`. Previously, when using the `kvm` | |
| accelerator, Nomad forced the machine type `host`. This is no longer true. Nomad | |
| now uses the value for `machine_type` . Additionally, if using `resources.cores` | |
| with the `kvm` accelerator, the `-smp` used that number of cores. Nomad now only | |
| uses the `resources.cores` value when you have not specified a custom `-smp` | |
| flag. |
Member
Author
There was a problem hiding this comment.
I had to refactor this paragraph a good bit after refactoring my PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links
Code PR: hashicorp/nomad#27179
Contributor checklists
Review urgency:
Pull request:
Content:
Reviewer checklist