Update axum monorepo #6816
Open
Update axum monorepo #6816
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hash-worker[bot]](https://avatars.githubusercontent.com/in/991899?s=80&v=4){kind=small}
|
hashdotai
previously approved these changes
Mar 29, 2025
github-actions
bot
added
the
area/deps
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
eb8238b to
44694e0
Compare
hashdotai
previously approved these changes
Apr 25, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
44694e0 to
8a47b67
Compare
hashdotai
previously approved these changes
Apr 30, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
8a47b67 to
e5047a0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6816 +/- ##
==========================================
- Coverage 54.68% 54.68% -0.01%
==========================================
Files 1093 1093
Lines 97283 97283
Branches 4544 4544
==========================================
- Hits 53200 53199 -1
- Misses 43495 43496 +1
Partials 588 588
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
e5047a0 to
2a13f0e
Compare
hashdotai
previously approved these changes
Jun 23, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
2a13f0e to
7a4f4c5
Compare
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
7a4f4c5 to
50ffe8e
Compare
hashdotai
previously approved these changes
Jul 14, 2025
hashdotai
previously approved these changes
Jul 21, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
63b2bcc to
e0f82f5
Compare
hashdotai
previously approved these changes
Jul 28, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
e0f82f5 to
2eee581
Compare
hashdotai
previously approved these changes
Sep 1, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
2eee581 to
d7cee0e
Compare
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
d7cee0e to
eef795b
Compare
hashdotai
previously approved these changes
Sep 27, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
eef795b to
9e53e0b
Compare
hashdotai
previously approved these changes
Sep 28, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
9e53e0b to
9b27c64
Compare
hashdotai
previously approved these changes
Sep 28, 2025
hash-worker
bot
force-pushed
the
deps/rs/axum-monorepo
branch
from
9b27c64 to
efa4b08
Compare
hashdotai
approved these changes
Sep 30, 2025
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments:
libs/@local/graph/api/src/rest/principal.rs (line 128):
Axum 0.8 changed path parameter syntax from /:param to /{param}, but the code still uses the old syntax which will cause compilation errors.
View Details
📝 Patch Details
diff --git a/libs/@local/graph/api/src/rest/principal.rs b/libs/@local/graph/api/src/rest/principal.rs
index f22269ce0..123d892c8 100644
--- a/libs/@local/graph/api/src/rest/principal.rs
+++ b/libs/@local/graph/api/src/rest/principal.rs
@@ -102,9 +102,9 @@ impl PrincipalResource {
Router::new().nest(
"/identifier",
Router::new()
- .route("/:identifier", get(get_machine_by_identifier::<S>))
+ .route("/{identifier}", get(get_machine_by_identifier::<S>))
.route(
- "/system/:identifier",
+ "/system/{identifier}",
get(get_or_create_system_machine::<S>),
),
),
@@ -113,7 +113,7 @@ impl PrincipalResource {
"/ai",
Router::new().route("/", post(create_ai_actor::<S>)).nest(
"/identifier",
- Router::new().route("/:identifier", get(get_ai_by_identifier::<S>)),
+ Router::new().route("/{identifier}", get(get_ai_by_identifier::<S>)),
),
),
)
@@ -125,34 +125,34 @@ impl PrincipalResource {
Router::new()
.route("/", post(create_org_web::<S>))
.nest(
- "/:web_id",
+ "/{web_id}",
Router::new()
.route("/", get(get_web_by_id::<S>))
.route("/roles", get(get_web_roles::<S>)),
)
- .route("/shortname/:shortname", get(get_web_by_shortname::<S>)),
+ .route("/shortname/{shortname}", get(get_web_by_shortname::<S>)),
)
.nest(
"/teams",
Router::new()
.nest(
- "/:team_id",
+ "/{team_id}",
Router::new().route("/roles", get(get_team_roles::<S>)),
)
- .route("/name/:name", get(get_team_by_name::<S>)),
+ .route("/name/{name}", get(get_team_by_name::<S>)),
)
.nest(
- "/:actor_group_id",
+ "/{actor_group_id}",
Router::new().nest(
"/roles",
Router::new()
- .route("/actors/:actor_id", get(get_actor_group_role::<S>))
+ .route("/actors/{actor_id}", get(get_actor_group_role::<S>))
.nest(
- "/:role/actors",
+ "/{role}/actors",
Router::new()
.route("/", get(get_actor_group_role_assignments::<S>))
.route(
- "/:actor_id",
+ "/{actor_id}",
post(assign_actor_group_role::<S>)
.delete(unassign_actor_group_role::<S>),
),
Analysis
Axum 0.8 runtime panic due to deprecated path parameter syntax
What fails: Router creation in PrincipalResource::routes() panics at runtime with 11 route definitions using the old :param syntax (lines 105, 107, 116, 128, 133, 139, 142, 145, 149, 151, 155)
How to reproduce:
# Start the graph API server - it will panic immediately on router creation
cargo run --bin hash-graphResult: Runtime panic: "Path segments must not start with :. For capture groups, use {capture}. If you meant to literally match a segment starting with a colon, call without_v07_checks on the router."
Expected: Server should start without panic using the new Axum 0.8 syntax {param} instead of :param
Per Axum 0.8 announcement, path parameter syntax changed from /:single to /{single}. The old syntax now causes runtime panics unless .without_v07_checks() is called on the router.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
=0.7.5->=0.8.6=0.5.0->=0.5.5Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
tokio-rs/axum (axum)
v0.8.6Compare Source
v0.8.5: axum v0.8.5Compare Source
OptionalFromRequestforMultipart(#3220)Location::{status_code, location}middleware::ResponseAxumBodyLayerfor mapping response body toaxum::body::Body(#3469)impl FusedStream for WebSocket(#3443)ssemodule andSsetype no longer depend on thetokiofeature (#3154)Redirects constructors is not a valid header value, instead of panicking on construction, theIntoResponseimpl now returns an HTTP 500, just likeJsondoes when serialization fails (#3377)v0.8.4: axum v0.8.4Compare Source
Router::reset_fallback(#3320)WebSocketUpgrade::selected_protocol(#3248)servewithout graceful shutdown (#3129)v0.8.3: axum v0.8.3Compare Source
From<Bytes>forMessage(#3273)OptionalFromRequestforJson(#3142)OptionalFromRequestforExtension(#3157)WebSocketUpgrade(#3178)v0.8.2: axum v0.8.2Yanked from crates.io due to unforeseen breaking change, see #3190 for details
OptionalFromRequestforJson(#3142)OptionalFromRequestforExtension(#3157)statusfunction of rejections aconstfunction, suchas
JsonRejection,QueryRejectionandPathRejection(#3168)v0.8.0: axum v0.8.0Compare Source
since rc.1
axum::extract::ws::Messagenow usesBytesin place ofVec<u8>,and a new
Utf8Bytestype in place ofString, for its variants (#3078)OptionalFromRequestPartsimpl forQuery(#3088)tokio-tungsteniteto 0.26 (#3078)serde_path_to_errorto report fields that failed to parse (#3081)full changelog
You can also read the blog post on tokio
Note: there are further relevant changes in axum-core's changelog
/:singleand/*manyto/{single}and/{*many}; the old syntax produces a panic to avoid silent change in behavior (#2645)Syncfor all handlers and services added toRouterandMethodRouter(#2473)Pathextractor deserializers now check that the number of parameters matches the tuple length exactly (#2931)Hostextractor toaxum-extra(#2956)WebSocket::close. Users should explicitly send close messages themselves. (#2974)servegeneric over the listener and IO types (#2941)Serve::tcp_nodelayandWithGracefulShutdown::tcp_nodelay.See
serve::ListenerExtfor an API that let you set arbitrary TCP stream properties. (#2941)Option<Path<T>>no longer swallows all error conditions,instead rejecting the request in many cases; see its documentation for details (#2475)
axum::extract::ws::Messagenow usesBytesin place ofVec<u8>,and a new
Utf8Bytestype in place ofString, for its variants (#3078)serde_json::RawValueinEvent::json_data(#2992)content-lengthbefore middleware.This allows middleware to add bodies to requests without needing to manually set
content-length(#2897)tokio-tungsteniteto 0.26 (#3078)serde_path_to_errorto report fields that failed to parse (#3081)method_not_allowed_fallbackto set a fallback when a path matches but there is no handler for the given HTTP method (#2903)NoContentas a self-described shortcut forStatusCode::NO_CONTENT(#2978)get(ws_endpoint)handlers toany(ws_endpoint)(#2894)MethodFilter::CONNECT,routing::connect[_service]andMethodRouter::connect[_service](#2961)FailedToDeserializePathParams::kindenum with (ErrorKind::DeserializeError). This new variant captures bothkey,value, andmessagefrom named path parameters parse errors, instead of only deserialization error message inErrorKind::Message. (#2720)v0.7.9: axum - v0.7.9Compare Source
v0.7.8: axum - v0.7.8Compare Source
serde_json::RawValueinEvent::json_data(#2992)method_not_allowed_fallbackto set a fallback when a path matches but there is no handler for the given HTTP method (#2903)MethodFilter::CONNECT,routing::connect[_service]and
MethodRouter::connect[_service](#2961)NoContentas a self-described shortcut forStatusCode::NO_CONTENT(#2978)v0.7.7: axum - v0.7.7Compare Source
rustdoc now generates tables of content in the sidebar (#2921)
v0.7.6: axum - v0.7.6Compare Source
Arcduring deserialization ofPathaxum::serve::Serve::tcp_nodelayandaxum::serve::WithGracefulShutdown::tcp_nodelay(#2653)Router::has_routesfunction (#2790)Serve::local_addrandWithGracefulShutdown::local_addrfunctions (#2881)Configuration
📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.