-
Notifications
You must be signed in to change notification settings - Fork 105
Update Rust crate oxc
to v0.95.0
#7613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
bd94a28
to
e1d07ea
Compare
e1d07ea
to
3d9b4d6
Compare
oxc
to v0.77.0oxc
to v0.77.1
3d9b4d6
to
95f477e
Compare
oxc
to v0.77.1oxc
to v0.77.2
95f477e
to
d8268f7
Compare
oxc
to v0.77.2oxc
to v0.77.3
d8268f7
to
eaeff9d
Compare
oxc
to v0.77.3oxc
to v0.78.0
oxc
to v0.90.0oxc
to v0.91.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7613 +/- ##
==========================================
- Coverage 55.22% 55.19% -0.03%
==========================================
Files 1103 1103
Lines 98465 98386 -79
Branches 4584 4582 -2
==========================================
- Hits 54373 54307 -66
+ Misses 43472 43459 -13
Partials 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7f08222
to
7a5f018
Compare
oxc
to v0.91.0oxc
to v0.92.0
7a5f018
to
74c0f52
Compare
74c0f52
to
e290560
Compare
oxc
to v0.92.0oxc
to v0.93.0
e290560
to
a225c73
Compare
oxc
to v0.93.0oxc
to v0.94.0
a225c73
to
025d66f
Compare
oxc
to v0.94.0oxc
to v0.95.0
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff
at https://github.com/hashintel/hash/actions/runs/18521597079
opentelemetry_sdk = { version = "=0.30.0", default-features = false } | ||
owo-colors = { version = "=4.2.2", default-features = false } | ||
oxc = { version = "=0.67.0", default-features = false, features = ["allocator_api"] } | ||
oxc = { version = "=0.95.0", default-features = false, features = ["allocator_api"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oxc = { version = "=0.95.0", default-features = false, features = ["allocator_api"] } | |
oxc = { version = "=0.67.0", default-features = false, features = ["allocator_api"] } |
The oxc dependency version update is ineffective because a git patch on line 388 overrides the workspace dependency version.
View Details
Analysis
oxc dependency version update ineffective due to git patch override
What fails: Workspace dependency update to oxc = "=0.95.0"
on line 195 has no effect because [patch.crates-io]
entry on line 388 overrides it with git commit 333f583e
(version 0.67.0)
How to reproduce:
# Test crates.io version 0.95.0 alone (fails - missing allocator_api feature):
cargo new test && cd test
echo 'oxc = { version = "=0.95.0", features = ["allocator_api"] }' >> Cargo.toml
cargo check
# Error: oxc does not have allocator_api feature
# Test with git patch (works - has allocator_api feature):
echo '[patch.crates-io]\noxc = { git = "https://github.com/TimDiekmann/oxc", rev = "333f583e" }' >> Cargo.toml
cargo check
# Downloads dependencies successfully (version 0.67.0 from git)
Result: Project continues using oxc 0.67.0 from git repository instead of intended 0.95.0 from crates.io
Expected: Version update should take effect, or patch should be updated to compatible commit with 0.95.0+ features
Reference: Cargo patch documentation confirms patches override workspace dependencies during resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the reason why it fails. And it's overwritten because we wait on the upstream issue to be fixed.
This PR contains the following updates:
=0.67.0
->=0.95.0
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.