-
Notifications
You must be signed in to change notification settings - Fork 105
ES-17: Remove deprecated features #7763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7763 +/- ##
==========================================
+ Coverage 54.85% 54.90% +0.04%
==========================================
Files 1083 1084 +1
Lines 96635 96588 -47
Branches 4537 4538 +1
==========================================
+ Hits 53010 53031 +21
+ Misses 43035 42968 -67
+ Partials 590 589 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit b2245af.
Put on hold until we do other breaking changes. The issue about the |
Benchmark results
|
Function | Value | Mean | Flame graphs |
---|---|---|---|
resolve_policies_for_actor | user: empty, selectivity: high, policies: 10002 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: medium, policies: 5001 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: high, policies: 27604 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 13450 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: high, policies: 11308 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: medium, policies: 5628 | Flame Graph |
policy_resolution_large
Function | Value | Mean | Flame graphs |
---|---|---|---|
resolve_policies_for_actor | user: empty, selectivity: high, policies: 2002 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: medium, policies: 1001 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: high, policies: 3314 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 1526 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: high, policies: 2078 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: medium, policies: 1033 | Flame Graph |
policy_resolution_medium
Function | Value | Mean | Flame graphs |
---|---|---|---|
resolve_policies_for_actor | user: empty, selectivity: high, policies: 102 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: medium, policies: 51 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: high, policies: 269 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 107 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: high, policies: 133 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: medium, policies: 63 | Flame Graph |
policy_resolution_none
Function | Value | Mean | Flame graphs |
---|---|---|---|
resolve_policies_for_actor | user: empty, selectivity: high, policies: 2 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: medium, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: high, policies: 8 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: medium, policies: 3 | Flame Graph |
policy_resolution_small
Function | Value | Mean | Flame graphs |
---|---|---|---|
resolve_policies_for_actor | user: empty, selectivity: high, policies: 52 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: empty, selectivity: medium, policies: 25 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: high, policies: 94 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 26 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: high, policies: 66 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
resolve_policies_for_actor | user: system, selectivity: medium, policies: 29 | Flame Graph |
representative_read_entity
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1
|
Flame Graph |
representative_read_entity_type
Function | Value | Mean | Flame graphs |
---|---|---|---|
get_entity_type_by_id | Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba
|
Flame Graph |
representative_read_multiple_entities
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph | |
entity_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
entity_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
entity_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
entity_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
entity_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph |
scaling_read_entity_complete_one_depth
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | 1 entities | Flame Graph | |
entity_by_id | 10 entities | Flame Graph | |
entity_by_id | 25 entities | Flame Graph | |
entity_by_id | 5 entities | Flame Graph | |
entity_by_id | 50 entities | Flame Graph |
scaling_read_entity_complete_zero_depth
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | 1 entities | Flame Graph | |
entity_by_id | 10 entities | Flame Graph | |
entity_by_id | 25 entities | Flame Graph | |
entity_by_id | 5 entities | Flame Graph | |
entity_by_id | 50 entities | Flame Graph |
scaling_read_entity_linkless
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | 1 entities | Flame Graph | |
entity_by_id | 10 entities | Flame Graph | |
entity_by_id | 100 entities | Flame Graph | |
entity_by_id | 1000 entities | Flame Graph | |
entity_by_id | 10000 entities | Flame Graph |
🌟 What is the purpose of this PR?
With the release of
[email protected]
we can remove the deprecated features. This will take effect from0.7.0
onwards.Note: We should wait to merge until we do other breaking changes. This gives us the option to still release
0.6.1
if we want/need to.🚫 Blocked by
error-stack
0.6.0 #7762🔍 What does this change?
Remove
Context
attach_printable
,attach_printable_lazy
,attach_lazy
report!
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: