Skip to content

Conversation

@indietyp
Copy link
Member

@indietyp indietyp commented Jan 3, 2026

🌟 What is the purpose of this PR?

Rename the PreInlining pass to PreInline for consistency with other transform passes in the codebase. This includes renaming the associated files, module references, and test directories.

🔍 What does this change?

  • Renamed PreInlining class to PreInline in the MIR transform passes
  • Renamed pre_inlining.rs file to pre_inline.rs
  • Updated all import references to use the new name
  • Moved test files from pre_inlining directory to pre_inline
  • Updated suite name from "mir/pass/transform/pre-inlining" to "mir/pass/transform/pre-inline"
  • Updated all function names and references from mir_pass_transform_pre_inlining to mir_pass_transform_pre_inline

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🛡 What tests cover this?

Existing tests were moved to the new directory structure and continue to cover the functionality.

❓ How to test this?

  1. Run the existing test suite to verify that the renamed components work correctly
  2. Verify that all imports and references to the renamed components are working properly

@vercel vercel bot temporarily deployed to Preview – petrinaut January 3, 2026 16:34 Inactive
@cursor
Copy link

cursor bot commented Jan 3, 2026

PR Summary

Standardizes naming of the MIR pre-inlining pass.

  • Rename PreInlining -> PreInline and move pre_inlining.rs -> pre_inline.rs; update re-exports in transform/mod.rs
  • Update compiletest: mir_pass_transform_pre_inlining -> mir_pass_transform_pre_inline, suite struct to MirPassTransformPreInline, and suite name to "mir/pass/transform/pre-inline"
  • Update usages in mir_pass_transform_inline.rs to call mir_pass_transform_pre_inline
  • Switch benchmarks to PreInline in mir/benches/transform.rs
  • Move tests to mir/tests/ui/pass/pre_inline/ with new .spec.toml and refreshed golden outputs

Written by Cursor Bugbot for commit 8ea1aed. This will update automatically on new commits. Configure here.

Copy link
Member Author

indietyp commented Jan 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (ebf1893) to head (8ea1aed).

Additional details and impacted files
@@                                Coverage Diff                                 @@
##           bm/be-270-hashql-simplify-aggregate-to-unit-const    #8238   +/-   ##
==================================================================================
  Coverage                                              83.72%   83.72%           
==================================================================================
  Files                                                     88       88           
  Lines                                                  12083    12083           
  Branches                                                 317      317           
==================================================================================
  Hits                                                   10117    10117           
  Misses                                                  1850     1850           
  Partials                                                 116      116           
Flag Coverage Δ
rust.hashql-compiletest 46.65% <ø> (ø)
rust.hashql-mir 89.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@augmentcode
Copy link

augmentcode bot commented Jan 3, 2026

🤖 Augment PR Summary

Summary: Renames the MIR pre-inlining transform pass to PreInline for naming consistency.

Changes:

  • Renamed PreInliningPreInline and pre_inlining.rspre_inline.rs, updating module exports.
  • Updated compiletest suites/bench pipelines and helper function names to use the new identifiers.
  • Moved UI test fixtures/spec from pre_inlining to pre_inline and updated the suite string to mir/pass/transform/pre-inline.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing bm/be-268-hashql-rename-preinlining-to-preinline (8ea1aed) with bm/be-270-hashql-simplify-aggregate-to-unit-const (ebf1893)

Summary

✅ 17 untouched benchmarks

@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
ds-theme Ignored Ignored Preview Jan 15, 2026 3:23pm
hashdotdesign Ignored Ignored Preview Jan 15, 2026 3:23pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

2 participants