-
Notifications
You must be signed in to change notification settings - Fork 110
BE-268: HashQL: Rename PreInlining to PreInline for consistency #8238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bm/be-270-hashql-simplify-aggregate-to-unit-const
Are you sure you want to change the base?
BE-268: HashQL: Rename PreInlining to PreInline for consistency #8238
Conversation
PR SummaryStandardizes naming of the MIR pre-inlining pass.
Written by Cursor Bugbot for commit 8ea1aed. This will update automatically on new commits. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bm/be-270-hashql-simplify-aggregate-to-unit-const #8238 +/- ##
==================================================================================
Coverage 83.72% 83.72%
==================================================================================
Files 88 88
Lines 12083 12083
Branches 317 317
==================================================================================
Hits 10117 10117
Misses 1850 1850
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: Renames the MIR pre-inlining transform pass to Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
a01405e to
f6a654b
Compare
6603ad7 to
d04ffb4
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
f6a654b to
ebf1893
Compare
d04ffb4 to
8ea1aed
Compare

🌟 What is the purpose of this PR?
Rename the
PreInliningpass toPreInlinefor consistency with other transform passes in the codebase. This includes renaming the associated files, module references, and test directories.🔍 What does this change?
PreInliningclass toPreInlinein the MIR transform passespre_inlining.rsfile topre_inline.rspre_inliningdirectory topre_inlinemir_pass_transform_pre_inliningtomir_pass_transform_pre_inlinePre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
Existing tests were moved to the new directory structure and continue to cover the functionality.
❓ How to test this?