-
Notifications
You must be signed in to change notification settings - Fork 110
H-5998: Version fixes for JS package publishing #8261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR SummaryAligns versions and publishing behavior for JS packages.
Written by Cursor Bugbot for commit dba97ee. This will update automatically on new commits. Configure here. |
🤖 Augment PR SummarySummary: Adjusts Changesets and package versions to unblock future JS package publishing and avoid unintended major/minor bumps. Changes:
Technical Notes: This should allow Changesets to bump 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review completed. No suggestions at this time.
Comment augment review to trigger a new review at any time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR prepares the JavaScript package publishing infrastructure by correcting version numbers and changeset configuration. It standardizes versions for @hashintel/ds-helpers and @hashintel/ds-components from pre-release tags to proper semantic versions, downgrades a Petrinaut version bump from minor to patch, and excludes the deprecated @hashintel/petrinaut-old package from the changeset workflow.
Changes:
- Updated
@hashintel/ds-helpersand@hashintel/ds-componentsfrom pre-release versions (0.0.1-band0.0.1-c) to0.0.1 - Changed the Petrinaut changeset from
minortopatchbump - Added
@hashintel/petrinaut-oldto the changeset ignore list
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
libs/@hashintel/ds-helpers/package.json |
Updated package version from 0.0.1-b to 0.0.1 |
libs/@hashintel/ds-components/package.json |
Updated package version from 0.0.1-c to 0.0.1 and dependency reference |
libs/@hashintel/petrinaut/package.json |
Updated dependency references to use 0.0.1 instead of pre-release versions |
yarn.lock |
Updated lockfile entries to reflect version changes |
.changeset/empty-forks-flow.md |
Changed Petrinaut version bump from minor to patch |
.changeset/config.json |
Added @hashintel/petrinaut-old to the ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@local/*", | ||
| "@rust/*", | ||
| "@tests/*", | ||
| "@hashintel/petrinaut-old" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| "@hashintel/petrinaut": minor | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this. Indeed better to keep patches only for now.
🌟 What is the purpose of this PR?
Some fixes which will allow us to merge #8255 when we choose to, and publish public JS packages:
minortopatch(at this early< 1.0.0stage we'll just keep patching until something seems significant enough for a minor, by some fuzzy criteria TBC)@hashintel/ds-helpersand@hashintel/ds-componentsversion to0.0.1so that changesets correctly bumps them to0.0.2– it is currently setting them to1.0.0, it doesn't understand the weird not-really-semver I used to publish manually a few versions before.@hashintel/petrinaut-oldfor the purpose of changeset, so it doesn't attempt to publish it. This means that publishing merging Version Packages #8255 is not blocked on removing that package from the repo.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
❓ How to test this?
Once it's merged we'll need to check the diff on #8255 to see if the desired changes mentioned above are correctly implemented:
ds-helpersandds-componentsbumped to0.0.2@hashintel/petrinaut-old