Skip to content

Write cracked hashes to log that have been skipped #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s3inlc merged 3 commits into from
Mar 27, 2025
Merged

Write cracked hashes to log that have been skipped #1199

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
116f802
Write cracked hashes to log that have been skipped
Mar 19, 2025
59e812c
Changed log, to not log the hash
Mar 19, 2025
dd23a01
Fixed code review suggestions
Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/inc/api/APISendProgress.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,14 @@ public function execute($QUERY = array()) {
$qF3 = new QueryFilter(Hash::IS_CRACKED, 0, "=");
$hashes = Factory::getHashFactory()->filter([Factory::FILTER => [$qF1, $qF2, $qF3]]);
if (sizeof($hashes) == 0) {
//This can happen if agent rebuild the hash incorrectly
//Log the skipped hash so that admin can spot this false negative
$logMessage = "Hash has been cracked but skipped! This happened while cracking hashlist with Id: "
. $hashlist->getId() . " during chunk with id: " . $chunk->getId() . " This happens when the agent returns
a cracked hash that Does not exist in the database. This can happen when hashcat malforms the hash";
Util::createLogEntry(DLogEntryIssuer::API, $this->agent->getToken(), DLogEntry::FATAL, $logMessage);
DServerLog::log(DServerLog::FATAL, $logMessage);

$skipped++;
break;
}
Expand Down