Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
## Enhancements

- Use utf8mb4 as default encoding in order to support the full unicode range
- Log hashes when they are skipped. This way the administrator can detect when Hashcat rebuilds the hashes incorrectly

## Bugfixes

Expand Down
8 changes: 8 additions & 0 deletions src/inc/api/APISendProgress.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,14 @@ public function execute($QUERY = array()) {
$qF3 = new QueryFilter(Hash::IS_CRACKED, 0, "=");
$hashes = Factory::getHashFactory()->filter([Factory::FILTER => [$qF1, $qF2, $qF3]]);
if (sizeof($hashes) == 0) {
//This can happen if agent rebuild the hash incorrectly
//Log the skipped hash so that admin can spot this false negative
$logMessage = "Hash has been cracked but skipped! This happened while cracking hashlist with ID: "
. $hashlist->getId() . " during chunk with ID: " . $chunk->getId() . " This happens when the agent returns
a cracked hash that does not exist in the database. This can happen when hashcat malforms the hash.";
Util::createLogEntry(DLogEntryIssuer::API, $this->agent->getToken(), DLogEntry::FATAL, $logMessage);
DServerLog::log(DServerLog::FATAL, $logMessage);

$skipped++;
break;
}
Expand Down