Skip to content

1593 bug taskwrappers weird state when tasks have been deleted #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpascal123 merged 2 commits into from
Sep 19, 2025
Merged

1593 bug taskwrappers weird state when tasks have been deleted #1595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
310af41
Deletes taskwrapper when last task has been deleted
Sep 18, 2025
9e072b7
Made it possible to signal if a relationship is readonly, and made th…
Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/inc/apiv2/common/AbstractModelAPI.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,6 +1526,9 @@ protected function updateToManyRelationship(Request $request, array $data, array
if ($relationKey == null) {
throw new HttpError("Relation does not exist!");
}
if ($relation["readonly"] === true) {
throw new HttpError("This relationship is readonly");
}

$relationType = $relation['relationType'];
$features = $this->getFeaturesOther($relationType);
Expand Down Expand Up @@ -1593,7 +1596,10 @@ public function postToManyRelationshipLink(Request $request, Response $response,
$relation = $this->getToManyRelationships()[$args['relation']];
$relationKey = $relation['relationKey'];
if ($relationKey == null) {
throw new HttpError("Relation does not exist!");
throw new HttpError('Relation does not exist!');
}
if ($relation['readonly'] === true) {
throw new HttpError('This relationship is readonly');
}

// check if the object queried exists
Expand Down
1 change: 1 addition & 0 deletions src/inc/apiv2/model/taskwrappers.routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public static function getToManyRelationships(): array {

'relationType' => Task::class,
'relationKey' => Task::TASK_WRAPPER_ID,
'readonly' => true // Not allowed to change tasks of a taskwrapper
],
];
}
Expand Down
5 changes: 5 additions & 0 deletions src/inc/utils/TaskUtils.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,11 @@ public static function deleteTask($task) {
$qF = new QueryFilter(Chunk::TASK_ID, $task->getId(), "=");
Factory::getChunkFactory()->massDeletion([Factory::FILTER => $qF]);
Factory::getTaskFactory()->delete($task);
$taskWrapper = Factory::getTaskWrapperFactory()->get($task->getTaskWrapperId());
// If last task of taskwrapper has been deleted, delete taskwrapper aswell
if (count(self::getTasksOfWrapper($taskWrapper->getId())) === 0) {
Factory::getTaskWrapperFactory()->delete($taskWrapper);
}
LockUtils::deleteLockFile($task->getId());
}

Expand Down