Skip to content

[WIP] Fix invalid credentials message on login page #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

[WIP] Fix invalid credentials message on login page #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f56494
Initial plan
Copilot Oct 7, 2025
96a079b
Improve login error messages for invalid credentials
Copilot Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/v2/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function __invoke(array $arguments): bool {
"path" => "/api/v2/auth/token",
"secure" => false,
"error" => function ($response, $arguments) {
return errorResponse($response, $arguments["message"], 401);
return errorResponse($response, "Invalid credentials. Please check your username and password.", 401);
},
"authenticator" => new HashtopolisAuthenticator,
"before" => function ($request, $arguments) {
Expand Down
2 changes: 1 addition & 1 deletion src/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
UI::addMessage(UI::ERROR, "You need to fill in both fields!");
break;
case '3':
UI::addMessage(UI::ERROR, "Wrong username/password/OTP!");
UI::addMessage(UI::ERROR, "Invalid credentials. Please check your username, password" . (Util::isYubikeyEnabled() ? ", and OTP" : "") . ".");
break;
case '4':
UI::addMessage(UI::ERROR, "You need to be logged in to view this! Please log in again.");
Expand Down