Skip to content

Conversation

@Eric-Wasson
Copy link

@Eric-Wasson Eric-Wasson commented Nov 20, 2025

Added backend handling of overwriting the plaintext on importing pre-cracked hashes as well as upload pre-cracked hashlists and upload using URL.

UI todos before merge:

  • A new checkbox input field on the new UI is needed (checkbox name: "overwrite"). Because the checkbox is currently missing, a "Required parameter not specified" error is thrown when trying to import pre-cracked hashes.
  • The separator is hardcoded to ":", the user should be able to set it with an input field like on the old UI (text input field with the name "separator").
  • Use the same handling that's used for the create new hashlist, i.e. the upload file option does a POST-request to importFile first to create the file, then uses PATCH to add the data and then does the POST to importCrackedHashes to import the uploaded file. Also the upload by URL can be added on the frontend now (but currently that's not implemented on the create hashlist frontend either).

@Eric-Wasson Eric-Wasson requested a review from jessevz November 20, 2025 12:46
@Eric-Wasson Eric-Wasson added enhancement Enhancement of existing features / Small addition server Hashtopolis API/Server related ui Hashtopolis UI related labels Nov 20, 2025
@Eric-Wasson Eric-Wasson changed the title Added backend handling of overwriting on import pre-cracked hashes Added backend handling of overwriting on import pre-cracked hashes and import by file and URL Nov 21, 2025
@jessevz
Copy link
Contributor

jessevz commented Dec 2, 2025

This pull request crashes in the build process because of an update to php 8.5. in the dev branch i have pinned it to 8.4. if you merge the dev branch into this branch, it should pass the build process

@Eric-Wasson Eric-Wasson moved this from Todo to Review in 🎄X-Mas Sprint December '25 Dec 3, 2025
@Eric-Wasson Eric-Wasson moved this to 🚧 In progress in 🍂 Sprint November '25 Dec 3, 2025
@Eric-Wasson Eric-Wasson marked this pull request as ready for review December 3, 2025 08:08
@Eric-Wasson Eric-Wasson removed the server Hashtopolis API/Server related label Dec 3, 2025
@Eric-Wasson Eric-Wasson moved this from Review to Todo in 🎄X-Mas Sprint December '25 Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of existing features / Small addition ui Hashtopolis UI related

Projects

Status: 🚧 In progress

Development

Successfully merging this pull request may close these issues.

3 participants