Skip to content

promr9dna4kh_rad004 degrade profile (1 bit) added#148

Merged
hiruna72 merged 2 commits into
devfrom
degrade_profiles
Mar 16, 2025
Merged

promr9dna4kh_rad004 degrade profile (1 bit) added#148
hiruna72 merged 2 commits into
devfrom
degrade_profiles

Conversation

@hiruna72
Copy link
Copy Markdown
Collaborator

image

@hasindu2008
Copy link
Copy Markdown
Owner

This is R9 flowcell, right? If so, for consistency with other profiles and looking at the values above, I suggest we go with "2" rather than "1".

@hiruna72 hiruna72 merged commit f812295 into dev Mar 16, 2025
@hasindu2008
Copy link
Copy Markdown
Owner

Hi hiruna
For any upcoming profiles, we do not need to have a test case as this feature is well tested now over many profiles. Even this case be removed (can do it in the next pull request as this is already merged), especially because the test files are massive (like 7mb) and thus the repo size will go out of control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants