Rework VALUES clause and fix a bug on SQLite #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentRDC
approved these changes
Mar 11, 2025
| (\_ -> Nothing) snd) | ||
| where | ||
| useAliases = knownBool @(BeamSqlBackendSupportsColumnAliases be) | ||
| colAliases | useAliases = Just fieldNames |
There was a problem hiding this comment.
Is there a reason to use type-level bools for this? Seems like a typeclass method using either mkFieldNames or mkDefaultFieldNames might be more straightforward
There was a problem hiding this comment.
Good point.. yeah that would be easier
| @@ -479,7 +479,7 @@ instance IsSql92TableNameSyntax TableName where | |||
| data TableSource | |||
| = TableNamed TableName | |||
| | TableFromSubSelect Select | |||
| | TableFromValues [ [ Expression ] ] | |||
| | TableFromValues Int [ [ Expression ] ] | |||
There was a problem hiding this comment.
Would love to see a little comment here about what this Int represents
There was a problem hiding this comment.
This is the number of columns in the result (in the case that the expressions list is empty, we wouldn't be able to infer that from the values).
There was a problem hiding this comment.
I meant as documentation, just like you did in tableFromValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an old bug #326 by factoring out all SQLite VALUEs into common table expressions, which seems to be the approach the SQLite manual takes to naming VALUE columns.