Fix try haskell on Android

[andys8]

Fix

Cherrypicked fix provided in chrisdone-archive/jquery-console#71.

Tested on desktop, iOS, and Android - with Android now working. There is also another comment confirming the fix.

Fixes #252

Review

I would welcome another person making sure "try it" is still working on desktop as before (comparing with currently deployed https://haskell.org).

Hint for review: I needed to change the listening host to 0.0.0.0 in order to be able to access the local dev server via my mobile device in the same network.

diff --git a/builder/site.hs b/builder/site.hs
index c5869dd..a56877b 100644
--- a/builder/site.hs
+++ b/builder/site.hs
@@ -66,7 +66,7 @@ main = mkContext >>= \ctx -> hakyllWith configuration $ do
 
 
 configuration :: Configuration
-configuration = defaultConfiguration{ providerDirectory = "site" }
+configuration = defaultConfiguration{ providerDirectory = "site", previewHost = "0.0.0.0" }
 
 parseTestimonialCompiler :: Compiler (Item Testimonial)
 parseTestimonialCompiler = do

Demo

Record_2023-02-03-19-54-48.mp4

[tomjaguarpaw]

For me, on desktop, it doesn't seem to allow entering space or numerals.

[andys8]

Oh, man, then it's not as easy as applying the suggested fix. Will take a look :D

[andys8]

I pushed a change where copied the file from the fork over as is.

The result seems to be that it's working on Android and Desktop. On Android sometimes the number input seems to be a bit flaky, but better than before. Before I could confirm the same behavior you described.

Why didn't I do this in the first place? The fork has some formatting chances, so I thought I could only use the lines that fix logic. But also: The file of the fork has 845 lines while the file in the haskell-infra repository has only 750 lines. The difference is significant. I haven't looked into it and don't know if these differences are improvements, or code that was actively stripped away to run it on haskell.org.

I'd first test the current experience, if it's a fix at all, and then the difference should be investigated.

[tomjaguarpaw]

The latest version seems to be fine on desktop.

[andys8]

ℹ️ This change is coming from this commit: chrisdone-archive/jquery-console@3d405bf

[andys8]

ℹ️ This change is coming from this commit: chrisdone-archive/jquery-console@c8812e4

[andys8]

I compared the changes other changes in jquery-console. I think - other than the actual fix - they are commits missing from upstream and formatting by the fix author. So I don't think these chances were intended to be missing, and therefore should be most likely fine to be merged, too.

Btw. ignoring white space helps a lot with github's diff.

[andys8]

@tomjaguarpaw Good to merge?

[TikhonJelvis]

Makes sense to me, but would be great to have @tomjaguarpaw give it a quick test too.

[tomjaguarpaw]

When I tried it on desktop it was fine so let's give this a go. I don't really understand how it works, but if anyone spots any problems after merge we can always roll back.

[andys8]

if anyone spots any problems after merge we can always roll back

Exactly. Thanks for merging

[tomjaguarpaw]

Thanks for contributing!