Made collapsable elements visible when javascript is disabled - #385
Merged
Conversation
collapsable elements that are controlled via javascript now have , and elements that toggled the collapsable elements have (the latter may potentially need reverting)
Collaborator
|
Seems like a reasonable approach. Let's give it a go. |
tomjaguarpaw
requested review from
Kleidukos,
Tritlo,
abailly,
aviaviavi,
doyougnu and
rebeccaskinner
July 4, 2026 18:04
rebeccaskinner
approved these changes
Jul 4, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384
Originally I opted to put all collapsible sections inside
<details>tags, but it proved difficult to get the animations right for this.Instead, I think this is a good middle ground. All elements with the
.collapseclass are set todisplay: block;, and all[data-toggle="collapse"]elements are set todisplay: none;.The result is collapsed areas are visible, and the elements that toggle the collapsing behavior are hidden (this might want to be reverted though). The site is a little less pretty to those with JavaScript disabled, though.