fix(admin): make creation unsafe and wait for response #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranVanBelle
force-pushed
the
fix/ensure-topic-is-created
branch
from
4b221ac to
3c8e7d4
Compare
JoranVanBelle
force-pushed
the
fix/ensure-topic-is-created
branch
2 times, most recently
from
f07f172 to
324d368
Compare
JoranVanBelle
force-pushed
the
fix/ensure-topic-is-created
branch
from
324d368 to
75f6b77
Compare
There was a problem hiding this comment.
Pull Request Overview
Updates the CI workflow to use newer action versions, streamline caching, and replace deprecated syntax for workflow outputs
- Bumps
actions/cachefrom v2 to v3 for librdkafka - Replaces
action-works/cabal-cachewithactions/cache@v4for Cabal artifacts - Updates Haskell setup action and migrates away from
set-output
Files not reviewed (2)
- src/Kafka/Internal/RdKafka.chs: Language not supported
- src/Kafka/Topic.hs: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/haskell.yml:35
- The action name
haskell-actions/setup@v2appears incorrect; the official Haskell setup action isactions-haskell/setup@v2.
- - uses: haskell-actions/setup@v2
.github/workflows/haskell.yml:49
- [nitpick] Indent list items consistently (usually two spaces) to improve readability and prevent YAML parsing issues.
- - name: Cache ~/.cabal/packages, ~/.cabal/store and dist-newstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AlexeyRaga
While using the library, I noticed that when the cluster was down and I tried to create a topic, it would not complain.
With this adaptation, it will complain if it cannot create the topic