Skip to content

Comments

RGB Light + Float Outputs#3

Open
alexyao2015 wants to merge 5 commits intomainfrom
rgblight-output
Open

RGB Light + Float Outputs#3
alexyao2015 wants to merge 5 commits intomainfrom
rgblight-output

Conversation

@alexyao2015
Copy link
Member

@alexyao2015 alexyao2015 commented Jan 20, 2021

Currently, override whatever gamma correct/transition length is set by the user to 0. We can choose to leave it like this or

For gamma correct:

  1. Ignore gamma correct on the intermediary light and tell the user to set it to 0.
  2. Set gamma correct to 0 on each light call (seems to be a poor idea since constantly setting it)
  3. Forcibly override it like it currently does

For transition length: (If transition length is not 0, it will likely cause weird things to happen)

  1. Add transition length 0 to the light call on each call.
  2. Tell the user to set the default to 0
  3. Forcibly override it like it currently does

Side effect: large amounts of logs from the intermediary light.

fixes #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Todo: Use RGB light with float outputs

1 participant