🐛 Pass --verbose to AdGuard Home in debug mode#694
Conversation
The debug branch appended the --verbose flag to a misspelled `option` array instead of the `options` array that is actually passed to the AdGuard Home binary. As a result, setting the log level to debug or trace never enabled AdGuard Home's own verbose logging.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesDebug verbose flag variable correction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed Changes
The AdGuard Home run script builds the command line in an
optionsarray, but the debug branch appended the--verboseflag to a misspelledoptionarray (singular) instead:Because the flag landed in a throwaway variable, it was never passed to the AdGuard Home binary. Setting the app's
log_leveltodebugortracetherefore never enabled AdGuard Home's own verbose logging, which is exactly what that setting is meant to do when troubleshooting.This fixes the typo so
--verboseis added to theoptionsarray that is actually executed.Related Issues
Summary by CodeRabbit