Skip to content

🐛 Pass --verbose to AdGuard Home in debug mode#694

Merged
frenck merged 1 commit into
mainfrom
fix-verbose-flag
Jun 11, 2026
Merged

🐛 Pass --verbose to AdGuard Home in debug mode#694
frenck merged 1 commit into
mainfrom
fix-verbose-flag

Conversation

@frenck

@frenck frenck commented Jun 11, 2026

Copy link
Copy Markdown
Member

Proposed Changes

(Describe the changes and rationale behind them)

The AdGuard Home run script builds the command line in an options array, but the debug branch appended the --verbose flag to a misspelled option array (singular) instead:

declare -a options
...
if bashio::debug; then
  option+=(--verbose)
fi

exec ./AdGuardHome "${options[@]}"

Because the flag landed in a throwaway variable, it was never passed to the AdGuard Home binary. Setting the app's log_level to debug or trace therefore never enabled AdGuard Home's own verbose logging, which is exactly what that setting is meant to do when troubleshooting.

This fixes the typo so --verbose is added to the options array that is actually executed.

Related Issues

(Github link to related issues or pull requests)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed verbose mode not being correctly enabled for AdGuard when running in debug mode.

The debug branch appended the --verbose flag to a misspelled `option`
array instead of the `options` array that is actually passed to the
AdGuard Home binary. As a result, setting the log level to debug or
trace never enabled AdGuard Home's own verbose logging.
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 24eeaebf-7efa-4c23-81f1-a193e6094fc7

📥 Commits

Reviewing files that changed from the base of the PR and between 4718890 and 71f7832.

📒 Files selected for processing (1)
  • adguard/rootfs/etc/s6-overlay/s6-rc.d/adguard/run

Walkthrough

The run script for the AdGuard Home service corrects a single-line bug where the --verbose flag appended under debug conditions is now properly added to the options array instead of a non-existent option variable.

Changes

Debug verbose flag variable correction

Layer / File(s) Summary
Debug verbose flag appending
adguard/rootfs/etc/s6-overlay/s6-rc.d/adguard/run
The --verbose flag is appended to the options array via options+=(--verbose) in debug mode instead of the incorrect option variable, ensuring verbose mode is passed to the AdGuardHome executable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Hops of joy! One line did flee,
From wrong option to rightful array spree,
The verbose flag now finds its place,
In options bright—debug finds grace! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main bugfix: correcting verbose flag passing to AdGuard Home in debug mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-verbose-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit 89e95c0 into main Jun 11, 2026
14 checks passed
@frenck frenck deleted the fix-verbose-flag branch June 11, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant