Skip to content

Keep php85-openssl installed at runtime#537

Merged
frenck merged 1 commit into
hassio-addons:mainfrom
citizenserious:fix-runtime-openssl
Apr 22, 2026
Merged

Keep php85-openssl installed at runtime#537
frenck merged 1 commit into
hassio-addons:mainfrom
citizenserious:fix-runtime-openssl

Conversation

@citizenserious

@citizenserious citizenserious commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

This keeps php85-openssl installed in the runtime image instead of only installing it as a build dependency.

Grocy performs the OpenFoodFacts lookup at runtime over HTTPS, so php85-openssl must remain available after the build dependencies are removed.

So this may address #534

Summary by CodeRabbit

  • Chores
    • Adjusted Docker image dependencies to ensure security libraries are available at runtime for improved application stability and SSL/TLS support.

@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1593fec0-6fc9-4201-ad2b-0e51f4a3f318

📥 Commits

Reviewing files that changed from the base of the PR and between c12e563 and 924d227.

📒 Files selected for processing (1)
  • grocy/Dockerfile

Walkthrough

The php85-openssl package is relocated from the build-time-only dependency section to the runtime dependency section in the Dockerfile, making OpenSSL available throughout the image lifecycle rather than only during the build stage.

Changes

Cohort / File(s) Summary
Runtime Dependency Configuration
grocy/Dockerfile
Moved php85-openssl package from build-time dependencies to main runtime dependencies, ensuring OpenSSL availability in the final image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A package moved from build to stay,
OpenSSL's here to play all day!
From temporary scaffolds to forever runtime,
The Dockerfile blooms in perfect time! 🌱✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and clearly describes the main change: moving php85-openssl from build-time only to runtime installation in the Docker image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@citizenserious citizenserious deleted the fix-runtime-openssl branch April 17, 2026 23:26
@citizenserious citizenserious restored the fix-runtime-openssl branch April 17, 2026 23:27
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Apr 22, 2026

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @citizenserious 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 3e91614 into hassio-addons:main Apr 22, 2026
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants