Allow serving / funneling even if HA is set up with HTTPS/SSL#702
Allow serving / funneling even if HA is set up with HTTPS/SSL#702dynamyc010 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe ChangesSSL-aware Home Assistant connection
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Have you tested this before submitting a PR? Because it doesn't work. Execute in the app's container You have to run HA on http and use NGINX proxy app to proxy it through https on your non-TS connections. |
|
One configuration change I did have to change was telling the Funnel to use 8443 instead of 443, as something seems to take up 443 somewhere, and I didn't debug that yet. Outside access still works without using a port just fine. |
|
OK, you are right! I tested above with NGINX https->http proxy in the queue, that proxy answered 502 for the TS proxy, but when I add to HA config, then everything works (after some browser cache, etc. cleanup). Hmmm, I remember it failed with some certificate error 2 years ago, it seems TS fixed something. When I have time, I will check what is needed in NGINX to make it work (OK, it's unrelated), and make some changes to this PR (it's easier to do than explain, some docs, some refactoring, you will see), I mark it draft until. |


Proposed Changes
Ever since I switched my Home Assistant instance over to my own homelab SSL, it caused Serve and Funnel to not function (as they really want to use HTTP over HTTPS).
Since Tailscale supports serving HTTPS even if it doesn't trust the cert (with HTTPS+Insecure), I just refactored the run script to add support for it.
Related Issues
I couldn't find any issues for it, but since it was such a small thing relatively, I just did it myself in like an hour.
Testing
I tested in my own environment, Tailscale starts up properly and the Funnel is served properly as well now.
Summary by CodeRabbit