Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
06440600fileWhy
In
initcontainermode the proxy callsRefresh()directly, so the provider-specificwriteFile()mode is what lands on the sharedemptyDir. Before this change,file_azure_key_vaultwrote files with0600whilefile_aws_secrets_managerwrote them with0777, which produced inconsistent readability across providers.Using
os.WriteFile(..., 0644)alone is not sufficient when the file already exists with a more restrictive mode, so the helper also callsos.Chmod(..., 0644)after writing.Testing
go test -vet=off ./provider -run TestWriteSecretFilego test -vet=off ./provider/aws_secrets_manager -run ^go test -vet=off ./provider/azure_key_vault -run ^go test -vet=off ./provider/aws_iam_auth_rds -run ^