Fix multiple relationships pointing to the same collection#88
Merged
codedmart merged 5 commits intoOct 5, 2025
Merged
Conversation
Member
|
This looks semantically correct to me, it's clear that we shouldn't have been dropping the Will need to figure out why Snowflake variables nested test is complaining |
Member
|
Note: Update our tests so every test has deterministic ordering |
codedmart
deleted the
djh/fix-multiple-relationships-to-the-same-collection
branch
This was referenced May 5, 2026
GavinRay97
added a commit
to hasura/ndc-hub
that referenced
this pull request
May 6, 2026
Bumps the MySQL connector to **v1.0.19**. > Re-opened from #742 on an upstream branch — fork PRs fail CI because GitHub Actions strips repo/org secrets from `pull_request` runs originating in forks. ## Changes Picks up [hasura/ndc-jvm-mono#97](hasura/ndc-jvm-mono#97) — *fix(mysql): apply unique table alias on self-referential relationship subqueries*. When a relationship's source and target are the same collection (e.g. `regions.parentRegionId → regions.id`), the correlated subquery was previously aliased with the same name as the outer table scan. MySQL resolved both sides of the join condition to the inner scope, producing a tautological self-comparison that silently returned no rows. Equivalent fix to [#88](hasura/ndc-jvm-mono#88) (Snowflake/Trino) applied to MySQL's `JSONGenerator.kt`. ## Release artifacts - Tag: [`mysql/v1.0.19`](https://github.com/hasura/ndc-jvm-mono/releases/tag/mysql/v1.0.19) - Image: `ghcr.io/hasura/ndc-jvm-mysql:v1.0.19` (linux/amd64, linux/arm64) - CLI: `ghcr.io/hasura/ndc-jvm-cli:v1.0.19-mysql` - Source commit: `631d37452f26c736ed073c04bdce37d55bbff814` - Tarball sha256: `abfaf09c97327fe5d6bd1e98ba4df2c6d6fd5577c5f60d8b00d3ee10f8b28af0` Original contributor: @qamar-hashmi. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed for both Snowflake and Trino. Augment wrote this, I have not run it, but this is the fix I would expect here.