Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the hardcoded SDK version lookup with a dynamic fetch that respects user npm configurations, adds error handling, and updates documentation.
- Use pacote’s
whereoption to honor.npmrcand other npm settings when fetching the latest SDK version. - Remove the hardcoded default SDK version and its getter from
context.ts. - Simplify imports and introduce fatal logging with process exit on failure.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/writer/package-json-writer.ts | Added where option for npm config resolution, removed fallback method, updated error handling |
| src/app/context.ts | Removed NDC_NODEJS_LAMBDA_SDK_VERSION constant and its getter method |
| changelog.md | Noted support for .npmrc in Unreleased section |
Comments suppressed due to low confidence (2)
src/app/writer/package-json-writer.ts:86
- The new getLatestNdcNodeJsLambdaSdkVersion function introduces network calls and error handling changes that aren't covered by existing tests; consider adding unit tests for both successful fetch and failure scenarios.
async function getLatestNdcNodeJsLambdaSdkVersion(): Promise<SemVer> {
src/app/writer/package-json-writer.ts:99
- [nitpick] Calling process.exit directly makes this function hard to test and may prevent proper cleanup; consider throwing an error and letting the caller decide how to handle termination.
exit(1);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.