Conversation
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors across the connector generation and schema parsing codebase, focusing on code readability, efficiency, and modernization. The most notable changes include replacing custom pointer functions with Go's built-in
new, refactoring string building for performance, updating dependencies to Go 1.26, and improving error formatting and type parsing.Modernization and Dependency Updates
Dockerfile.tmplandgo.mod.tmplfrom 1.25/1.24.12 to 1.26/1.26.1, ensuring compatibility with the latest language features and ecosystem improvements. [1] [2]Code Generation and Schema Template Improvements
toPtrfunction with the built-innewfor pointer creation in schema templates and testdata, simplifying code and leveraging standard library functionality. [1] [2] [3] [4] [5] [6] [7] [8]String Building and Parsing Refactors
strings.Builderfor improved performance and readability, particularly in type name generation and argument formatting. [1] [2] [3]strings.SplitSeqfor splitting enum and type parameter strings, and updated loops to iterate over the resulting sequence, enhancing parsing robustness. [1] [2]Error Handling and Formatting
fmt.Errorffor clearer error messages. [1] [2] [3]Code Clean-up and Utility Usage
maps.Copyfor flattening embedded object fields, streamlining struct parsing and reducing boilerplate.These changes collectively enhance maintainability, performance, and code clarity throughout the connector generation and schema parsing modules.