feat(alerts): telegram drop rules #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatamiarash7
requested changes
Sep 28, 2024
|
Hey @hatamiarash7 |
hatamiarash7
requested changes
Mar 14, 2025
alifiroozi80
commented
Mar 14, 2025
| params := url.Values{} | ||
| params.Add("chat_id", t.Chat) | ||
| params.Add("parse_mode", "markdownv2") | ||
| if t.Topic != "" { | ||
| params.Add("message_thread_id", t.Topic) | ||
| } | ||
| url := r.config.Notifier.Telegram.Host + r.config.Notifier.Telegram.Token + "/sendMessage?" + params.Encode() |
There was a problem hiding this comment.
Variable url collides with imported package name, that's why I changed it to u
alifiroozi80
commented
Mar 14, 2025
| @@ -43,8 +60,12 @@ func (r *Repository) CreateTelegramMessage(alert models.Alert) error { | |||
| return err | |||
| } | |||
|
|
|||
| for _, url := range urls { | |||
| r.CallTelegram(url, body) | |||
| for _, u := range urls { | |||
There was a problem hiding this comment.
Variable url collides with imported package name, that's why I changed it to u
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @hatamiarash7
This PR gets an optional
Dropentry filed as a[]string, and when the app wants to send alerts in Telegram channels, it first checks the slice, and if the alert matches with any item inside that slice, it simply drops it.