fix: small scheduler optimizations #2426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces two scheduler improvements: it wraps replenish calls with a timeout to surface slow DB reads, and it corrects snapshot counter behavior to avoid snapshotting on every iteration.
- Wrap replenish with a 2s context timeout inside the ticker loop.
- Increment the snapshot counter to control snapshot frequency.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+383
to
+389
| innerCtx, cancel := context.WithTimeout(ctx, 2*time.Second) | ||
| err := s.replenish(innerCtx, true) | ||
|
|
||
| if err != nil { | ||
| s.l.Error().Err(err).Msg("error replenishing slots") | ||
| } | ||
| cancel() |
There was a problem hiding this comment.
The 2-second timeout is a magic number. Consider extracting it into a named constant or configuration (e.g., replenishTimeout) to make it easier to tune and document intent.
mrkaye97
approved these changes
Oct 16, 2025
|
|
||
| s.exts.ReportSnapshot(sqlchelpers.UUIDToStr(s.tenantId), in) | ||
|
|
||
| count++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two small optimizations on the scheduler:
replenishmethod so we get errors if database reads are too slowType of change