Fix nil error in handleTaskBulkAssignedTask
#2427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrkaye97
reviewed
Oct 16, 2025
| } | ||
|
|
||
| d.l.Error().Err(err).Msgf("could not bulk retrieve inputs for %d tasks", len(bulkDatas)) | ||
| continue |
There was a problem hiding this comment.
I might need to look at the git history for this... do we want to continue here?
There was a problem hiding this comment.
It is leading to a nil map error in the following lines. We can make sure that BulkRetrieve always returns a non-nil map if the logic requires this to not continue the parent iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue when bulk retrieve for payload inputs returns an error by making sure to continue to the next iteration like the other operations in the same function do.
Type of change