Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| -- TODO: we can add CHECK CONSTRAINT for event types that require data_hash to be non-null. | ||
| data_hash BYTEA, | ||
| -- Can discuss: adds some flexibility for future hash algorithms | ||
| data_hash_alg TEXT, |
There was a problem hiding this comment.
Can this be an enum instead of TEXT?
There was a problem hiding this comment.
yeah, I think this is something we need to discuss - I'm not convinced that this hashing approach is the correct one to detect non-determinism, it's purely an idea right now. I agree that if we decide to take this approach we should use an enum
| -- Important: writers to v1_durable_event_log_entry should lock this row to increment the sequence value. | ||
| CREATE TABLE v1_durable_event_log_file ( | ||
| -- The id and inserted_at of the durable task which created this entry | ||
| durable_task_id BIGINT NOT NULL, |
There was a problem hiding this comment.
Are we thinking of having a separate v1_durable_task table given the naming used here?
There was a problem hiding this comment.
no, this was just to make it more clear that this is the durable task and doesn't refer to any child tasks which may have been triggered in the event history
| DURABLE_TASK_TRIGGER_KIND_MEMO = 3; | ||
| } | ||
|
|
||
| message DurableTaskRequestTrigger { |
There was a problem hiding this comment.
is the idea here that triggering children out of a durable task will be entirely separate from the normal trigger path?
| optional DurableEventListenerConditions wait_for_conditions = 5; | ||
| } | ||
|
|
||
| message DurableTaskResponseTriggerAck { |
There was a problem hiding this comment.
I think this name is a little confusing 😅 maybe I'm just not following, but I don't really get what it's supposed to represent
3 participants
Description
(currently a WIP)
Type of change