-
Notifications
You must be signed in to change notification settings - Fork 304
feat: multiple slot types #2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+10,296
−2,411
Merged
Changes from all commits
Commits
Show all changes
133 commits
Select commit
Hold shift + click to select a range
6584839
fix: more tests
mrkaye97 f7d56fc
lint
grutt 7bc6f1e
lint
grutt b1fb028
init
grutt 1c488e6
dynamic slot types
grutt 1980b70
with sdks
grutt 556a64b
lint docs
grutt 18d586b
naming
grutt a47ab41
cleanup
grutt d8bfcfe
consistency
grutt 0214225
cleanup
grutt eab6c3d
rm
grutt c953028
count
grutt c49e599
lint
grutt b8ed6b8
lint
grutt 866456a
lint
grutt d8b7b80
last lint...
grutt 6d99401
manual isort
grutt 00448a3
consistency
grutt 592c20a
cleanup
grutt ddd46cf
remove public params
grutt eb1fb00
remove unused cols
grutt d8ea590
fix lockfile
grutt b60049a
build
grutt c60af74
sort
grutt 19810ef
ratelimit race
grutt 921c249
py test
grutt 5d4f152
cleanup
grutt 6966e0a
naming
grutt d14701d
feedback
grutt e767985
last changes
grutt 1abb563
lint
grutt 5cacf7a
map fields
grutt ac942a7
chore: generate, lint
grutt 98aee05
chore: rename migration
grutt f650be6
generate py
grutt bc7de09
generate ts
grutt 91bcf97
lint
grutt db97f0c
fix test
grutt 964d5e6
fix: flaky test
grutt 4bfe0cc
Merge branch 'main' into feat--multiple-slot-types
grutt a2242a1
generate
grutt 40c4e20
chore: clean up schema
grutt 43ff71d
chore: remove unused durable slots param
grutt 77be9b1
fix: tenant scope queries
grutt 17faada
chore: upsert to create
grutt 269872e
chore: propagate contexts
grutt c88fc89
chore: sqlc helper
grutt 8eef84e
fix: validate slots gt 0
grutt 19575fb
chore: remove complexity
grutt ee2f1df
fix: tests
grutt fc3cf4c
ops: deadlock load test
grutt 7d8fc87
fix: migration
grutt 18eebc8
fix: tests
grutt 0514831
fix: sdk mapping
grutt d29eeb6
revert: tenant filter
grutt 1b0a201
chore: ci verify sed patch
grutt c88e85f
chore: pick a better example that uses sync
grutt 65d785b
test: configurable overhead for deadlock load test
grutt dc742fe
chore: optimizations
grutt 7a8f398
refactor: improve load test event pushing and timeout handling
grutt 1f8931a
chore: remove deadlock worktree subproject
grutt 7f90763
feat: multi-step migration
grutt a31b7ca
chore: remove unneeded cte order, align sql template
grutt eff0b91
fix: python type checking
grutt 946fc74
revert: py whitespace for some reason...
grutt c18751c
feat: simplify slots queries
grutt e16bcee
chore: move queries
grutt a405969
fix: add py type hints this back in...
grutt c62a521
chore: review feedback
grutt af97173
flyby: drop unused webhook
grutt 518fb0f
chore: tenant scope worker
grutt 405c220
fix: migration
grutt a0d7390
chore: remove test hooks
grutt 866bd78
fix: backwards compatible hash
grutt 984e358
refactor: improve slot handling
grutt f2b69ab
chore: remove isort configuration and related linting step
grutt 36978a8
Merge branch 'main' into feat--multiple-slot-types
grutt 25d0f15
chore: remove dev code
grutt 8705ef6
Merge branch 'main' into feat--multiple-slot-types
grutt db146b3
chore: lint
grutt 990e44c
chore: don't drop old maxRuns column
grutt 67cccb5
chore: var naming
grutt d79d7cd
refactor: go single worker per worker
grutt c4dc58c
refactor: update actionWithSlots to return error
grutt 803695c
fix: deadlock risk
grutt c83b21d
fix: available slot count
grutt ba5d269
feat: load online migration
grutt 4dbfb78
Merge branch 'main' into feat--multiple-slot-types
grutt 17cf59b
chore: lint
grutt dc8eb97
fix: tests
grutt 38b958a
chore: bump migrations
grutt e86c5f1
test: use pgmq
grutt 016fde8
fix: tests
grutt 4b4d0eb
fix: flaky test
grutt 10db10a
revert: tenant scoped query
grutt 8b5749c
Merge branch 'main' into feat--multiple-slot-types
grutt 6f0f437
fix: tests
grutt c56c6a7
fix: lease before ticker
grutt 9ac813f
Merge branch 'main' into feat--multiple-slot-types
grutt a59a484
fix: more power for tests
grutt 7b9e3d2
fix: valid ubicloud tags
grutt c927c03
Merge branch 'main' into feat--multiple-slot-types
grutt e246309
revert: remove test
grutt 6b2f526
fix: valid ubicloud
grutt 90fa2e8
feat: sdks backward compat with old engines
grutt 8cd2490
feat: add chaos worker script for testing deployments
grutt db6c758
feat: implement simple chaos test script for worker management and ta…
grutt 1ee54f0
feat: semantic version string
grutt ed4cc5f
Merge branch 'main' into feat--multiple-slot-types
grutt a3a53f8
chore: feedback
grutt 1684fb8
chore: lint
grutt f84f723
chore: feedback
grutt 71486d7
Merge branch 'main' into feat--multiple-slot-types
grutt 81e04ac
fix: legacy registered workers
grutt 5a60017
fix: lint
grutt d4fd8bb
chore: remove cleanup migration (moved to separate PR #3020)
grutt 3bf7b3b
Merge branch 'main' into feat--multiple-slot-types
grutt 1ca1f58
chore: generate
grutt 16a051b
Merge branch 'main' into feat--multiple-slot-types
grutt 7356d69
fx: insert conflict
grutt 1f468fe
chore: note
grutt 55dac99
fix: correct on conflict
grutt b527943
revert: add query that we are actually using
grutt 174bb13
Merge branch 'main' into feat--multiple-slot-types
grutt d3b3544
chore: generate
grutt 268eef1
chore: bump migration versions
grutt 5f6cbc7
task: generate
grutt 33f4413
generate: py
grutt bc7d8c4
fix: reorder
grutt 5b4ad7b
generate: ruby
grutt 7827c7a
add tmate
grutt fd76216
test: remove tmate
grutt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's possible, shouldn't we return the tag instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya we do... comment drift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait but the tag isn't an int, it needs to be a string right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh nvm, I see what you mean - I was looking at this commit, not the full diff 👍