remove ep buffer for port with dedicated hw fifo #3359
Merged
+1,197
−885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdc device omit ep buffer when hwfifo is supported
…t read pointer. More rename
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes intermediate endpoint buffers for USB endpoints with dedicated hardware FIFOs, optimizing memory usage and data transfer efficiency for certain USB controllers like DWC2.
- Introduces
CFG_TUD_EDPT_DEDICATED_HWFIFOconfiguration to enable direct hardware FIFO access without intermediate buffering - Refactors FIFO API to use
tu_fifo_access_mode_tenum withTU_FIFO_FIXED_ADDR_RW32mode for hardware FIFO operations - Updates CDC device class to conditionally allocate EP buffers only when hardware FIFOs are not available
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit-test/test/test_fifo.c | Reformatted code and added comprehensive test coverage for new FIFO access modes and edge cases |
| test/unit-test/project.yml | Added CFG_TUSB_FIFO_ACCESS_FIXED_ADDR_RW32 define for test builds |
| test/unit-test/CMakeLists.txt | New CMake build system for unit tests with Ceedling integration |
| test/hil/hil_test.py | Enhanced CDC tests with variable payload sizes and improved error messages |
| src/tusb_option.h | Added configuration options for dedicated hardware FIFO support and migrated to #pragma once |
| src/tusb.c | Modified stream transfer logic to support NULL ep_buf and use xfer_fifo API when available |
| src/portable/synopsys/dwc2/dcd_dwc2.c | Updated to use new tu_fifo_read_n_access/tu_fifo_write_n_access API with TU_FIFO_FIXED_ADDR_RW32 |
| src/portable/nuvoton/nuc505/dcd_nuc505.c | Updated commented-out code to use new FIFO access API |
| src/portable/microchip/samg/dcd_samg.c | Updated commented-out code to use new FIFO access API |
| src/device/usbd.c | Added CFG_TUD_EDPT_DEDICATED_HWFIFO guard for xfer_fifo implementation and formatting cleanup |
| src/common/tusb_private.h | Updated ep_buf comment to clarify NULL usage with dedicated hardware FIFOs |
| src/common/tusb_mcu.h | Migrated to #pragma once and removed TUP_MEM_CONST_ADDR definition |
| src/common/tusb_fifo.h | Refactored API to expose tu_fifo_access_mode_t and reorganized inline helper functions |
| src/common/tusb_fifo.c | Major refactoring: renamed internal functions, moved helpers to header, fixed mutex usage |
| src/class/cdc/cdc_device.c | Conditionally compiled EP buffers and improved wanted char search logic for hardware FIFO compatibility |
| docs/info/changelog.rst | Updated release date (contains error: year changed to 2025 instead of 2024) |
| .clang-format | Added PPIndentWidth configuration and removed ReflowComments option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ce examples having minimum 64 bytes fifo (fs)
# Conflicts: # src/common/tusb_fifo.h
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for port with dedicated hw fifo i.e writing data to device fifo instead of DMA. We can omit ep buffer for xfer_fifo() and pretty much normal edpt_xfer() TX direction. Currently only enabled this for dwc2 with cdc, midi device. Vendor is updated in the follow-up PR but need to be careful with no-buffer mode (edpt_xfer only)
Sum up