Few misc fixes #3369
Merged
Few misc fixes #3369
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR includes miscellaneous fixes across the codebase, addressing performance settings, concurrency issues, and developer tooling improvements.
Key Changes:
- Enables FSDEV_HAS_SBUF_ISO for STM32U0, resolving previous audio performance issues
- Fixes potential race condition in FIFO empty check by reading volatile indices to local variables
- Improves Python audio debug script with better signal handling, error codes, and matplotlib best practices
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/portable/st/stm32_fsdev/fsdev_stm32.h | Enables SBUF_ISO feature for STM32U0 after resolving performance issues |
| src/common/tusb_fifo.h | Fixes race condition in tu_fifo_empty() by reading volatile indices atomically |
| examples/device/uac2_speaker_fb/src/audio_debug.py | Improves script reliability with signal handling, proper exit codes, and axes-based plotting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.