fix: Round 3 creation bug #361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mahmoud Can you review these changes and suggest whether this require any more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #351
This PR fixes the issue where when we move to round 3 after finalizing round 4, it results in an unrelated error. That reason was because of a backend problem which was solved earlier. However that change was not reflected on the frontend which made the bug alive.
This PR updates the frontend to handle preview failures gracefully, avoids calling
preview_resultsfor ranking rounds, and prevents advancing a round until valid thresholds are available, ensuring the frontend reflects the backend’s constraints.