Skip to content

Feat: Add edit page warning #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItsAbhinavM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: Add edit page warning #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions frontend/src/components/Vote/VoteEdit.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
<cdx-button weight="quiet" action="progressive" v-if="isVoting('ranking')" @click="saveRanking">
<content-save-outline style="font-size: 6px" /> {{ $t('montage-round-save') }}
</cdx-button>

<cdx-button weight="quiet" action="default" @click="gobackToRound">
<ArrowLeftThick />
<span>Back to Round</span>
</cdx-button>
</div>
<div class="image-grid" :class="'grid-size-' + gridSize" v-if="!isVoting('ranking')">
<div v-for="image in votes" :key="image.id" class="gallery-image link" :class="getImageSizeClass()">
Expand Down Expand Up @@ -125,7 +130,7 @@
</template>

<script setup>
import { onMounted, onUnmounted, ref, watch } from 'vue'
import { onMounted, onUnmounted, ref, watch} from 'vue'
import _ from 'lodash'
import { useRouter, useRoute } from 'vue-router'
import { useI18n } from 'vue-i18n'
Expand All @@ -145,6 +150,10 @@ import { CdxButton, CdxSelect } from '@wikimedia/codex'
import { VueDraggableNext as draggable } from 'vue-draggable-next'
import ImageReviewDialog from './ImageReviewDialog.vue'

//Services
// import { EventBus } from 'vue-toastification' // Currently depricated
import { onBeforeRouteLeave } from 'vue-router'

// Icons
import ContentSaveOutline from 'vue-material-design-icons/ContentSaveOutline.vue'
import ImageSizeSelectActual from 'vue-material-design-icons/ImageSizeSelectActual.vue'
Expand All @@ -155,6 +164,8 @@ import ThumbDown from 'vue-material-design-icons/ThumbDown.vue'
import Star from 'vue-material-design-icons/Star.vue'
import ArrowExpandAll from 'vue-material-design-icons/ArrowExpandAll.vue'
import Heart from 'vue-material-design-icons/Heart.vue'
import ArrowRight from 'vue-material-design-icons/ArrowRight.vue'
import ArrowLeftThick from 'vue-material-design-icons/ArrowLeftThick.vue'

// Hooks
const { t: $t } = useI18n()
Expand Down Expand Up @@ -358,6 +369,13 @@ watch(locale, (newLocale) => {
dayjs.locale(newLocale)
})

const beforeUnloadListner = (event) => {
if (edits.value.length){
event.preventDefault()
event.returnValue="";
}
};

onMounted(() => {
getRoundDetails(voteId)
getPastVotes(voteId)
Expand All @@ -368,13 +386,30 @@ onMounted(() => {

handleResize()
window.addEventListener('resize', handleResize)
window.addEventListener('beforeunload',beforeUnloadListner)
})

const gobackToRound = () => {
router.push(`/vote/${round.value.link}`)
}

onBeforeRouteLeave((to,from,next)=> {
if (edits.value.length) {
if (confirm("There are unsaved changes. Are you sure you want to leave?")) {
next()
} else {
next(false)
}
} else {
next()
}
})

onUnmounted(() => {
if (editVoteContainer.value) {
editVoteContainer.value.removeEventListener('scroll', handleScroll)
}

window.removeEventListener('beforeunload',beforeUnloadListner)
window.removeEventListener('resize', handleResize)
})
</script>
Expand Down