delete artifacts from store - #473
Conversation
|
biggest concern on clean up is properly parsing mediatype as part of the switch within the CleanUp function but this seems to have solved the errors I was seeing where blobs within manifests weren't being marked as referenced UPDATE: fixed logic here so all layers are processed, should be ok now |
|
@CamrynCarter this seems to work well. You're awesome! My only current feedback is that it took me a few tries to realize that I wasn't supposed to include the registry as part of the ref. I feel like a common workflow would be to do a |
Signed-off-by: Zack Brady <zackbrady123@gmail.com>
amartin120
left a comment
There was a problem hiding this comment.
This still makes me a little nervous but everything looks good. I appreciate this, thanks.
* WIP delete artifacts * handle multiple matches * confirm deletion * --force flag for delete-artifact * clean up remaining unreferenced blobs * more robust handling of manifest structure * fixed loop to process all layers * tests pt 1 * fix tests * test order * updated tests for deleting chart and file * tool cleanup tests --------- Signed-off-by: Zack Brady <zackbrady123@gmail.com> Co-authored-by: Zack Brady <zackbrady123@gmail.com>
Please check below, if the PR fulfills these requirements:
Associated Links:
haulerto delete artifacts from thestore#202Types of Changes:
Proposed Changes:
Verification/Testing of Changes:
Additional Context: