feat: Add support for force registry relocation - #715
Open
eklatzer wants to merge 1 commit into
Open
Conversation
Signed-off-by: Eric Klatzer <eric@klatzer.at>
Contributor
Author
|
Hey @zackbradys and @amartin120, would be nice to get your opinion regarding this discussion. After defining a way to handle this, I would go on with the implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this PR is not meant to be merged and more the baseline for a discussion for a feature request.
We are using Rancher Hauler to sync container images and Helm charts to our airgapped registry. We are then customizing the imported assets (e.g. by building wrapper charts with additional resources and additional configuration). Additionally, we are building custom container images and Helm charts. We want to use Hauler in our airgapped environment to generate a haul that is based on the previously imported and also custom assets. The biggest challenge doing this, was the fact, that the Helm charts sometimes still reference public container images like
quay.io/argoproj/argocd:v3.5.0that need a rewrite to our internal registry for building the haul. In RKE2 we solve this topic using theregistries.yamldescribed in https://docs.rke2.io/install/private_registry using containerd rewrites.Do you know of any known architectures, solving this issue? Does Hauler already support this use-case?
Example usage of the current PR:
The change of the current PR just solves it to some degree, but having broader support for a
registries.yamllike the following one would be my proposal:Thanks in advance 😊