Skip to content

standardize handling of flags, env vars, and annotations - #723

Merged
zackbradys merged 3 commits into
mainfrom
standardize-inputs
Aug 10, 2026
Merged

standardize handling of flags, env vars, and annotations#723
zackbradys merged 3 commits into
mainfrom
standardize-inputs

Conversation

@zackbradys

Copy link
Copy Markdown
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Feature

Proposed Changes:

  • Added hauler.dev/store annotation so manifests for images, charts, and files can route its own content to a different store than --store
  • Added hauler.dev/retries annotation so manifests can override the number of retries
    • Added the HAULER_RETRIES env var for --retries
  • Centralized --tempdir/HAULER_TEMP_DIR resolution into StoreRootOpts.Store()
    • Replaces the three separate copies of the same fallback logic
  • Removed hauler.dev/rewrite, a annotation in manifests constant that was defined but intentionally never implemented based on the original PR for rewrites
  • Updated the env var listings in --help and verbose audit logging to include the vars above

Verification/Testing of Changes:

  • N/A

Additional Context:

  • N/A

@github-project-automation github-project-automation Bot moved this to To Triage in Hauler Aug 10, 2026
@zackbradys zackbradys self-assigned this Aug 10, 2026
@zackbradys
zackbradys requested a review from a team August 10, 2026 04:27
@zackbradys zackbradys added enhancement New feature or request size/L Denotes an issue/PR requiring a relatively large amount of work go Pull requests that update go code labels Aug 10, 2026
@zackbradys zackbradys moved this from To Triage to Testing in Hauler Aug 10, 2026
@zackbradys zackbradys added this to the Hauler v2.1.0 milestone Aug 10, 2026

@amartin120 amartin120 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed hauler.dev/rewrite, a annotation in manifests constant that was defined but intentionally never implemented based on the original PR for rewrites.

Huh? I thought this was a thing. @CamrynCarter? Am I going crazy again or am I just not reading this correctly?

@zackbradys

Copy link
Copy Markdown
Member Author

Removed hauler.dev/rewrite, a annotation in manifests constant that was defined but intentionally never implemented based on the original PR for rewrites.

Huh? I thought this was a thing. @CamrynCarter? Am I going crazy again or am I just not reading this correctly?

rewrite does work per artifact in the manifests, but from what I remember, it was intentional for it not to work globally in the manifest and there was no calls to it when searching the code base.

@amartin120

Copy link
Copy Markdown
Contributor

@zackbradys Ohhhh. Okay, that makes sense. Thanks.

@amartin120 amartin120 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackbradys
zackbradys merged commit a5d9343 into main Aug 10, 2026
8 checks passed
@zackbradys
zackbradys deleted the standardize-inputs branch August 10, 2026 16:51
@github-project-automation github-project-automation Bot moved this from Testing to Resolved in Hauler Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code size/L Denotes an issue/PR requiring a relatively large amount of work

Projects

Status: Resolved

Development

Successfully merging this pull request may close these issues.

2 participants