Add TYPO3 v12 compatibility for FormFinisherConfigurationProvider#12
Merged
Conversation
getYamlConfiguration() and load() with 3 params are only available in TYPO3 13+. On TYPO3 12, skip YAML config merging and call load() with just the persistence identifier. Add functional tests for email extraction from form finishers. https://claude.ai/code/session_01ASMFPdYbZqXbBzk6v6j7zi
Replaces the interleaved version checks with dedicated loadAllFormDefinitionsV12() and loadAllFormDefinitionsV13() methods. TYPO3 12 no longer touches form settings at all, and v13 settings logic is fully encapsulated in its own method. https://claude.ai/code/session_01ASMFPdYbZqXbBzk6v6j7zi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds TYPO3 v12 compatibility to the
FormFinisherConfigurationProviderclass. The implementation detects the TYPO3 version at runtime and uses the appropriate API for loading form definitions.Key Changes
Typo3Versionto determine which API to useloadAllFormDefinitionsV12(): Uses the simplified v12 API wherelistForms()andload()don't require settings parametersloadAllFormDefinitionsV13(): Uses the v13+ API where both methods requireformSettingsandtypoScriptSettingsparametersConfigurationManagerandExtFormConfigurationManagerfrom the main flow, instantiating them only when needed for v13Implementation Details