Make systemd dependency optional

[amon-ra]

I have tried to install hawaii-shell in gentoo without systemd but it requires it on some modules. I made it optional, and enabled it by default to mantain the same working mode.

[amon-ra]

Without the patches it does not compile

[plfiorini]

A log with the compile error would be helpful

[amon-ra]

If I left the code, I get this error:

Scanning dependencies of target HawaiiSigWatch_automoc
[  1%] Automatic moc for target HawaiiSigWatch
Generating moc_sigwatch.cpp
[  1%] Built target HawaiiSigWatch_automoc
Scanning dependencies of target HawaiiSigWatch
[  2%] Building CXX object 3rdparty/sigwatch/CMakeFiles/HawaiiSigWatch.dir/sigwatch.cpp.o
[  2%] Building CXX object 3rdparty/sigwatch/CMakeFiles/HawaiiSigWatch.dir/HawaiiSigWatch_automoc.cpp.o        
Linking CXX static library libHawaiiSigWatch.a
[  2%] Built target HawaiiSigWatch
Scanning dependencies of target hawaii_automoc
[  3%] Automatic moc for target hawaii
Generating moc_application.cpp
Generating moc_logindbackend.cpp
Generating moc_loginmanager.cpp
Generating moc_loginmanagerbackend.cpp
Generating moc_powermanager.cpp
Generating moc_processlauncher.cpp
Generating moc_screensaver.cpp
Generating moc_authenticator.cpp
Generating moc_sessioninterface.cpp
Generating moc_sessionmanager.cpp
[  3%] Built target hawaii_automoc
Scanning dependencies of target gitsha1-hawaii
[  3%] Built target gitsha1-hawaii
[  4%] Generating screensaveradaptor.cpp, screensaveradaptor.h
[  5%] Generating processlauncheradaptor.cpp, processlauncheradaptor.h
[  6%] Generating processlauncheradaptor.moc
[  6%] Generating screensaveradaptor.moc
Scanning dependencies of target hawaii
[  7%] Building CXX object compositor/CMakeFiles/hawaii.dir/application.cpp.o
[  8%] Building CXX object compositor/CMakeFiles/hawaii.dir/main.cpp.o                                         
[  9%] Building CXX object compositor/CMakeFiles/hawaii.dir/processlauncher.cpp.o                              
[ 10%] Building CXX object compositor/CMakeFiles/hawaii.dir/screensaver.cpp.o                                  
[ 10%] Building CXX object compositor/CMakeFiles/hawaii.dir/sessionmanager.cpp.o                               
[ 11%] Building CXX object compositor/CMakeFiles/hawaii.dir/loginmanager/loginmanager.cpp.o                    
[ 12%] Building CXX object compositor/CMakeFiles/hawaii.dir/loginmanager/loginmanagerbackend.cpp.o             
[ 13%] Building CXX object compositor/CMakeFiles/hawaii.dir/loginmanager/logindbackend.cpp.o                   
/root/hawaii-shell/compositor/loginmanager/logindbackend.cpp: En la función miembro ‘virtual int LogindBackend::takeDevice(const QString&)’:
/root/hawaii-shell/compositor/loginmanager/logindbackend.cpp:202:64: error: ‘major’ no se declaró en este ámbito
     msg.setArguments(QVariantList() << QVariant(major(s.st_rdev)) << QVariant(minor(s.st_rdev)));
                                                                ^
/root/hawaii-shell/compositor/loginmanager/logindbackend.cpp:202:94: error: ‘minor’ no se declaró en este ámbito
     msg.setArguments(QVariantList() << QVariant(major(s.st_rdev)) << QVariant(minor(s.st_rdev)));
                                                                                              ^
/root/hawaii-shell/compositor/loginmanager/logindbackend.cpp: En la función miembro ‘virtual void LogindBackend::releaseDevice(int)’:
/root/hawaii-shell/compositor/loginmanager/logindbackend.cpp:227:64: error: ‘major’ no se declaró en este ámbito
     msg.setArguments(QVariantList() << QVariant(major(s.st_rdev)) << QVariant(minor(s.st_rdev)));
                                                                ^
/root/hawaii-shell/compositor/loginmanager/logindbackend.cpp:227:94: error: ‘minor’ no se declaró en este ámbito
     msg.setArguments(QVariantList() << QVariant(major(s.st_rdev)) << QVariant(minor(s.st_rdev)));
                                                                                              ^
compositor/CMakeFiles/hawaii.dir/build.make:241: recipe for target 'compositor/CMakeFiles/hawaii.dir/loginmanager/logindbackend.cpp.o' failed
make[2]: *** [compositor/CMakeFiles/hawaii.dir/loginmanager/logindbackend.cpp.o] Error 1
CMakeFiles/Makefile2:269: recipe for target 'compositor/CMakeFiles/hawaii.dir/all' failed
make[1]: *** [compositor/CMakeFiles/hawaii.dir/all] Error 2
Makefile:146: recipe for target 'all' failed
make: *** [all] Error 2

[amon-ra]

I have merged all changes in one commit. ¿I have to create another pull request?

[plfiorini]

Thanks for posting the error.

If you push -f to your branch, git will update this PR.